tools: use Ubuntu 24.04 and Clang on GitHub actions

[targos]

This puts us closer to what V8 really supports.
GCC is still covered a lot by Jenkins CI.

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[targos]

Default Clang on ubuntu-24.04 is 18.1.3

[targos]

ubuntu-24.04 is currently unreliable.

[targos]

actions/runner-images#9959

[targos]

Looks like we've got something broken with the Clang build config:

=== release test-benchmark-napi ===
Path: benchmark/test-benchmark-napi
Error: --- stderr ---
node:internal/modules/cjs/loader:1215
  throw err;
  ^

Error: Cannot find module './build/Release/addon'
Require stack:
- /home/runner/work/node/node/benchmark/napi/ref/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1212:15)
    at Module._load (node:internal/modules/cjs/loader:1038:27)
    at wrapModuleLoad (node:internal/modules/cjs/loader:212:19)
    at Module.require (node:internal/modules/cjs/loader:1297:12)
    at require (node:internal/modules/helpers:123:16)
    at Object.<anonymous> (/home/runner/work/node/node/benchmark/napi/ref/index.js:3:15)
    at Module._compile (node:internal/modules/cjs/loader:1460:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1544:10)
    at Module.load (node:internal/modules/cjs/loader:1275:32)
    at Module._load (node:internal/modules/cjs/loader:1091:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/runner/work/node/node/benchmark/napi/ref/index.js' ]
}

Node.js v23.0.0-pre
node:assert:126
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at ChildProcess.<anonymous> (/home/runner/work/node/node/test/common/benchmark.js:28:12)
    at ChildProcess.emit (node:events:520:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}

Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/benchmark/test-benchmark-napi.js

[richardlau]

The addon didn't build:

https://github.com/nodejs/node/actions/runs/9315062604/job/25640471713?pr=53212#step:7:5466

../addon.c:53:37: error: incompatible function pointer types passing 'void (napi_env, void *, void *)' (aka 'void (struct napi_env__ *, void *, void *)') to parameter of type 'node_api_nogc_finalize' (aka 'void (*)(const struct napi_env__ *, void *, void *)') [-Wincompatible-function-pointer-types]
   53 |                                     IncrementCounter,
      |                                     ^~~~~~~~~~~~~~~~
../addon.c:7:27: note: expanded from macro 'NAPI_CALL'
    7 |     napi_status status = (call);                      \
      |                           ^~~~
/home/runner/work/node/node/out/Release/addons_headers/include/node/js_native_api.h:523:43: note: passing argument to parameter 'finalize_cb' here
  523 |                    node_api_nogc_finalize finalize_cb,
      |                                           ^
1 error generated.
make[2]: *** [addon.target.mk:106: Release/obj.target/addon/addon.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.<anonymous> (/home/runner/work/node/node/deps/npm/node_modules/node-gyp/lib/build.js:209:23)
gyp ERR! System Linux 6.8.0-1007-azure
gyp ERR! command "/home/runner/work/node/node/out/Release/node" "/home/runner/work/node/node/deps/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--directory" "/home/runner/work/node/node/benchmark/napi/ref" "--nodedir" "/home/runner/work/node/node/out/Release/addons_headers" "--python" "/opt/hostedtoolcache/Python/3.12.3/x64/bin/python3" "--loglevel" "info"
gyp ERR! cwd /home/runner/work/node/node/benchmark/napi/ref
gyp ERR! node -v v23.0.0-pre
gyp ERR! node-gyp -v v10.1.0
gyp ERR! not ok 

[targos]

Oh, interesting. I wouldn't expect tests to run if part of the build failed.

[targos]

@nodejs/node-api Could one of you have a look?

IIUC the bug is in

node/benchmark/napi/ref/addon.c

Lines 37 to 55 in 54035ac

	static void
	IncrementCounter(napi_env env, void* data, void* hint) {
	size_t* count = data;
	(*count) = (*count) + 1;
	}
	static napi_value
	NewWeak(napi_env env, napi_callback_info info) {
	napi_value result;
	void* instance_data;
	NAPI_CALL(env, napi_create_object(env, &result));
	NAPI_CALL(env, napi_get_instance_data(env, &instance_data));
	NAPI_CALL(env, napi_add_finalizer(env,
	result,
	instance_data,
	IncrementCounter,
	NULL,
	NULL));

[KevinEady]

Would either need to remove

node/benchmark/napi/ref/addon.c

Line 2 in 54035ac

#define NAPI_EXPERIMENTAL

Or change the type of IncrementCounter's env parameter to node_api_nogc_env. I'll bring this up for discussion in today's 31 May Node-API meeting.

[mhdawson]

We discussed today in the node-api team meeting, @targos can you just remove #define NAPI_EXPERIMENTAL from node/benchmark/napi/ref/addon.c as part of your PR? We think that is the right thing to do in this case.

[mhdawson]

With further discussion it would also be great if you could change line 38 to

IncrementCounter(node_api_nogc_env env, void* data, void* hint) {

In your PR. It won't be neeed without NAPI_EXPERIMENTAL but would be needed later. If that is not possible let @mhdawson know and he'll take a look at doing it.

[targos]

Thanks! I opened a separate PR: #53233 and also added the change here to see if it works with Clang.

[targos]

Here's a run for the daily built-lto workflow: https://github.com/targos/node/actions/runs/9348019879

[targos]

https://github.com/targos/node/actions/runs/9348075335

[targos]

Problem with LTO build:

[102/4178] LINK torque
FAILED: torque 
clang++ -pthread -rdynamic -fno-lto -m64 -m64  -flto  -o torque -Wl,--start-group obj/deps/v8/src/torque/torque.torque.o obj/tools/v8_gypfiles/libtorque_base.a obj/tools/v8_gypfiles/libv8_libbase.a  -ldl -lrt -Wl,--end-group
/usr/bin/ld: /usr/lib/llvm-18/bin/../lib/LLVMgold.so: error loading plugin: /usr/lib/llvm-18/bin/../lib/LLVMgold.so: cannot open shared object file: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

[targos]

https://github.com/targos/node/actions/runs/9348382550

[targos]

llvm-18-linker-tools is already the newest version (1:18.1.3-1).
llvm-18-linker-tools set to manually installed.

There's also:

bfd plugin: LLVM gold plugin has failed to create LTO module: Unknown attribute kind (91) (Producer: 'LLVM18.1.3' Reader: 'LLVM 17.0.6')

/cc @gengjiawen who added the job.

[gengjiawen]

@targos need to resolve conflicts.

[targos]

@MoLow can you review one last time? The setup is working now.

[nodejs-github-bot]

Landed in db09f62