Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: micro-optimize writable condition #53189

Merged
merged 1 commit into from
Jun 4, 2024
Merged

stream: micro-optimize writable condition #53189

merged 1 commit into from
Jun 4, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 28, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 28, 2024
@orgads
Copy link
Contributor Author

orgads commented May 29, 2024

Can you please run the CI?

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orgads orgads force-pushed the streams-uoptimize branch from b83c501 to 1755e63 Compare May 29, 2024 11:00
@orgads orgads changed the title streams: micro-optimize writable condition stream: micro-optimize writable condition May 29, 2024
@orgads
Copy link
Contributor Author

orgads commented May 29, 2024

The commit message had streams instead of stream. Fixed now, please retrigger CI.

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59512/

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2024
@orgads orgads force-pushed the streams-uoptimize branch from 1755e63 to 5975965 Compare May 30, 2024 09:55
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59538/

@orgads orgads force-pushed the streams-uoptimize branch from 5975965 to a66dd43 Compare May 30, 2024 20:51
@orgads
Copy link
Contributor Author

orgads commented May 30, 2024

Rebased, please retrigger CI.

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59553/

@orgads
Copy link
Contributor Author

orgads commented May 31, 2024

Are these failing tests known to be flaky?

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@mcollina
Copy link
Member

let's see

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59564/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59586/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59621/

@orgads
Copy link
Contributor Author

orgads commented Jun 2, 2024

Finally!

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 4, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 4, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53189
✔  Done loading data for nodejs/node/pull/53189
----------------------------------- PR info ------------------------------------
Title      stream: micro-optimize writable condition (#53189)
Author     Orgad Shaneh  (@orgads)
Branch     orgads:streams-uoptimize -> nodejs:main
Labels     author ready
Commits    1
 - stream: micro-optimize writable condition
Committers 1
 - Orgad Shaneh 
PR-URL: https://github.com/nodejs/node/pull/53189
Reviewed-By: Robert Nagy 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53189
Reviewed-By: Robert Nagy 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: micro-optimize writable condition
   ℹ  This PR was created on Tue, 28 May 2024 19:30:07 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083817619
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083824949
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2085069824
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-06-02T18:30:19Z: https://ci.nodejs.org/job/node-test-pull-request/59621/
- Querying data for job/node-test-pull-request/59621/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9364333050

mcollina
mcollina approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7d14d1f into nodejs:main Jun 4, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7d14d1f

RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@orgads @RafaelGSS
stream: micro-optimize writable condition
7c66b27 
PR-URL: #53189
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@orgads @sophoniie
stream: micro-optimize writable condition
c8c80f6 
PR-URL: nodejs#53189
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@orgads @bmeck
stream: micro-optimize writable condition
f74baf6 
PR-URL: nodejs#53189
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@orgads @marco-ippolito
stream: micro-optimize writable condition
44d4e09 
PR-URL: #53189
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@orgads @marco-ippolito
stream: micro-optimize writable condition
d02651c 
PR-URL: #53189
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orgads @nodejs-github-bot @mcollina @benjamingr @ronag @MoLow