Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix esm markdown file #53170

Merged
merged 1 commit into from
May 27, 2024
Merged

doc: fix esm markdown file #53170

merged 1 commit into from
May 27, 2024

Conversation

popmoore
Copy link
Contributor

  • Fix esm doc format

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 26, 2024
@deokjinkim
Copy link
Contributor

deokjinkim commented May 27, 2024 •
edited
Loading

@popmoore Thank you for your contribution. Please replace docs with doc in commit title.
Below is guidelines for commit message.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@popmoore popmoore changed the title docs: fix esm markdown file doc: fix esm markdown file May 27, 2024
@popmoore
Copy link
Contributor Author

@popmoore Thank you for your contribution. Please replace docs with doc in commit title. Below is guidelines for commit message. https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Hi @deokjinkim I changed the commit title, can you approve the CI workflows

@deokjinkim deokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2024
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@deokjinkim

This comment was marked as off-topic.

Sign in to view
@aduh95

This comment was marked as off-topic.

Sign in to view
@aduh95 aduh95 merged commit 72a4470 into nodejs:main May 27, 2024
20 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 27, 2024

Landed in 72a4470

targos pushed a commit that referenced this pull request Jun 1, 2024
@popmoore @targos
doc: fix format in esm.md
1702d26 
PR-URL: #53170
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@popmoore @sophoniie
doc: fix format in esm.md
51ce790 
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@popmoore @bmeck
doc: fix format in esm.md
d55f639 
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@popmoore @marco-ippolito
doc: fix format in esm.md
fcd8cde 
PR-URL: #53170
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@popmoore @marco-ippolito
doc: fix format in esm.md
3ac775b 
PR-URL: #53170
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@popmoore @nodejs-github-bot @deokjinkim @aduh95 @GeoffreyBooth @lpinca