Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing property in Cluster Ex. #5305

Closed
wants to merge 1 commit into from
Closed

Fix missing property in Cluster Ex. #5305

wants to merge 1 commit into from

Conversation

MrOutput
Copy link
Contributor

Cluster.setupMaster(options) Options object was missing an args property on the example.

@r-52 r-52 added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Feb 18, 2016
@jasnell
Copy link
Member

jasnell commented Feb 19, 2016

LGTM
@MrOutput ... can you please update the commit log to follow the common style guidelines described in https://github.com/nodejs/node/blob/master/CONTRIBUTING.md? Thank you!

@MrOutput
Copy link
Contributor Author

@jasnell Is this the correct format?

@jasnell
Copy link
Member

jasnell commented Feb 20, 2016

For the most part, yes! although Cluster doesn't need to be caps and the body of the commit message should wrap at 70 chars (that can be fixed by whomever lands the commit tho). Thank you very much!

@MrOutput
doc: add missing property in Cluster Ex.
f58d229 
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example.
@silverwind
Copy link
Contributor

Thanks! Landed in 9894c02.

@silverwind silverwind closed this Feb 27, 2016
silverwind pushed a commit that referenced this pull request Feb 27, 2016
@MrOutput @silverwind
doc: add missing property in cluster example
9894c02 
`Cluster.setupMaster(options)` Options object was missing an `args`
property on the example.

PR-URL: #5305
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2016
@MrOutput @rvagg
doc: add missing property in cluster example
f8c6701 
`Cluster.setupMaster(options)` Options object was missing an `args`
property on the example.

PR-URL: #5305
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2016
Closed
@MylesBorins
Copy link
Contributor

Adding LTS watch label. Please remove if not appropriate

@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

SGTM for LTS

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@MrOutput
doc: add missing property in cluster example
0605d41 
`Cluster.setupMaster(options)` Options object was missing an `args`
property on the example.

PR-URL: #5305
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@MrOutput
doc: add missing property in cluster example
d4cfc6f 
`Cluster.setupMaster(options)` Options object was missing an `args`
property on the example.

PR-URL: #5305
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrOutput @jasnell @silverwind @MylesBorins @r-52