Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: specify that preloaded modules affect subprocesses #52939

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

OnlyAviv
Copy link
Member

Fixes #52930

Marking author as Co-Author, as they specified where the preloaded modules will appear.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels May 10, 2024
@OnlyAviv OnlyAviv added the loaders Issues and PRs related to ES module loaders label Jun 2, 2024
@OnlyAviv OnlyAviv added the review wanted PRs that need reviews. label Aug 9, 2024
@OnlyAviv
Copy link
Member Author

OnlyAviv commented Aug 9, 2024

Hey, this hasn't seen any reviews or objections, just bumping it a bit.

@OnlyAviv
Copy link
Member Author

OnlyAviv commented Aug 19, 2024

@jasnell I think this is good to land?

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2bd6a57 into nodejs:main Sep 4, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2bd6a57

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
Co-Authored-By: Tim Fish <[email protected]>
PR-URL: #52939
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Co-Authored-By: Tim Fish <[email protected]>
PR-URL: nodejs#52939
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
Co-Authored-By: Tim Fish <[email protected]>
PR-URL: nodejs#52939
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. loaders Issues and PRs related to ES module loaders review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document more clearly that --require and --import can impact all threads and forked processes
5 participants