doc: improve unhandledException doc copy #5287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
doc
|
|
||
| Example of listening for `'uncaughtException'`: | ||
| For example: |
There was a problem hiding this comment.
Tiniest nit: consistent would be "Example:" afaik
|
Good one. LGTM, minus (nit and) conflicts. /cc @nodejs/documentation |
|
LGTM |
| listener is added for this exception, the default action (which is to print | ||
| a stack trace and exit) will not occur. | ||
| The `'uncaughtException'` event is emitted when an exception bubbles all the | ||
| way back to the event loop. By default, Node.js handles such exceptions by printing the stack trace to stderr and exiting. Adding a handler for the |
There was a problem hiding this comment.
Isn't this line longer than the usual limit?
There was a problem hiding this comment.
yep, will correct the wrapping on landing.
|
@nodejs/documentation ... can I get some more LGTM's on this from Collaborators? |
|
LGTM |
|
LGTM - the merge conflict. |
|
yep, will rebase before landing |
Rework the doc a bit to tighten it up, including removing the use of `you`
jasnell
force-pushed
the
doc-unhandled-exception-improvement
branch
from
1657b60 to
72d29e6
Compare
|
Rebased! |
jasnell
added a commit
that referenced
this pull request
Mar 3, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> ...
|
Landed in 831b30e |
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> ...
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> ...
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> ...
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the doc a bit to tighten it up, including removing the
use of
you