build,tools,node-api: fix building node-api tests for Windows Debug #52632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
lpinca
approved these changes
Apr 22, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
StefanStojanovic
approved these changes
Apr 22, 2024
targos
approved these changes
Apr 22, 2024
VoltrexKeyva
approved these changes
Apr 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Apr 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
vmoroz
force-pushed
the
pr/fix_node_api_tests_for_debug_config
branch
from
7cb971f to
2d78d59
Compare
Flarna
approved these changes
Apr 23, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
Apr 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2334d5c |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52632 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52632 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52632 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52632 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we run
.\vcbuild Debug build-node-api-testswe are getting an error that says:"Can not find out dir, did you run configure?"The issue is that the
tools/build_addons.pyhardcodesReleaseoutput path for Windows and compiling forDebugfails because theout\Releasefolder does not exists. For debug config we must useout\Debugpath instead.This new code was introduced in PR #50737.
This PR fixes the issue by adding the new
configparameter to thetools/build_addons.pywhich is used to find the default output directory. Thevcbuild.batis changed to pass the%config%variable to thetools/build_addons.py.