test_runner: fix clearing final timeout inside own callback #52332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
approved these changes
Apr 3, 2024
atlowChemi
approved these changes
Apr 3, 2024
cjihrig
approved these changes
Apr 3, 2024
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Apr 6, 2024
MoLow
pushed a commit
that referenced
this pull request
Apr 11, 2024
PR-URL: #52332 Fixes: #52325 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in 3f8cc88 |
|
landed manually, CI completed but GitHub bot seems to not work (probably reached some limit du to ci unlocked after security release) |
richardlau
added
lts-watch-v18.x
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52332 Fixes: #52325 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52332 Fixes: #52325 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52325
Clearing the final mocked timeout left in the execution queue inside its own callback causes an error to be thrown when trying to access its
idbecause it is not treated as nullable.