lib: .load .save add proper error message when no file passed #52225
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a proper error message using ERR_MISSING_ARGS('file')
when a .save or .load REPL command is runned. This commit also adds
test for both of this cases.
Fixes: nodejs#52218
Signed-off-by: Thomas Mauran <[email protected]>
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cola119
approved these changes
Mar 30, 2024
|
@thomas-mauran Thank you for your contribution! The changes look good to me, but the linters have flagged some style issues. Could you please address them? |
Signed-off-by: Thomas Mauran <[email protected]>
|
Hello @cola119 I applied the lint correction I think the test will pass now |
cola119
approved these changes
Mar 31, 2024
cola119
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hello @cola119 and @mertcanaltin I'm not sure of what should I do for the failed test ? |
|
They are flaky tests, so I re-run the CI. |
|
still some didn't pass @cola119 idk if it's because of the flaky test ? my pr shouldn't affect them |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Retrying CI... |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cola119
approved these changes
Apr 3, 2024
github-actions
bot
added
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cola119
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
cola119
added
commit-queue-squash
|
nice test seems to have passed ! thank you @cola119 |
cola119
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3f5ff8d |
|
@thomas-mauran Thank you for your contribution! I apologize for some flaky tests that prolonged the time it took for our CI to pass. I'm looking forward to your continued contributions in the future! |
|
no problem at all thanks for taking the time ! |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
This commit adds a proper error message using ERR_MISSING_ARGS('file')
when a .save or .load REPL command is runned. This commit also adds
test for both of this cases.
Fixes: #52218
Signed-off-by: Thomas Mauran <[email protected]>
PR-URL: #52225
Reviewed-By: Kohei Ueno <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
This commit adds a proper error message using ERR_MISSING_ARGS('file')
when a .save or .load REPL command is runned. This commit also adds
test for both of this cases.
Fixes: #52218
Signed-off-by: Thomas Mauran <[email protected]>
PR-URL: #52225
Reviewed-By: Kohei Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a proper error message using ERR_MISSING_ARGS('file') when a .save or .load REPL command is runned. This commit also adds test for both of this cases.
Fixes: #52218