doc: add mold to speeding up section #52179

congzhangzh · 2024-03-21T17:08:16Z

C/C++ link is slow, especially for node like projects, which will link GBs data to 100MB like size
C/C++ link process can not be cached
mold is really really fast

congzhangzh · 2024-03-21T17:13:36Z

@H4ad Hi Vinicius, can you review this document improve?

H4ad · 2024-03-22T16:38:47Z

@congzhangzh Sorry for the delay, this PR looks good to me, do you still want to close?

sxa · 2024-03-22T18:20:49Z

The first time I tried mold on my aarch64 system it crashed on me but it was ok on the second attempt , but assuming this was a one-off I reckon I'd be 👍🏻 on this suggestion to end users.

congzhangzh · 2024-03-22T23:31:18Z

@H4ad @sxa hi folks, please merge if you guys accept :)

The fork repo deleted unconditionally, and I restored it from GitHub support:)

H4ad · 2024-03-23T02:39:29Z

Please, just fix the lint issues:

Using release list from env...
BUILDING.md is not formatted. Please run 'make format-md'.
BUILDING.md
             warning Remove trailing whitespace                    no-trailing-spaces  remark-lint
534:162      warning Line must be at most 80 characters            maximum-line-length remark-lint
537:84       warning Line must be at most 80 characters            maximum-line-length remark-lint
573:4-573:39 warning Don’t use literal URLs without angle brackets no-literal-urls     remark-lint
574:4-574:34 warning Don’t use literal URLs without angle brackets no-literal-urls     remark-lint

congzhangzh · 2024-03-23T03:17:09Z

Please, just fix the lint issues:

Using release list from env...
BUILDING.md is not formatted. Please run 'make format-md'.
BUILDING.md
             warning Remove trailing whitespace                    no-trailing-spaces  remark-lint
534:162      warning Line must be at most 80 characters            maximum-line-length remark-lint
537:84       warning Line must be at most 80 characters            maximum-line-length remark-lint
573:4-573:39 warning Don’t use literal URLs without angle brackets no-literal-urls     remark-lint
574:4-574:34 warning Don’t use literal URLs without angle brackets no-literal-urls     remark-lint

@H4ad Hi Vinicius, I fixed it by make format-md :)

congzhangzh · 2024-03-23T08:52:59Z

@H4ad @sxa @anonrig Hi folks, please review again, sorry for these repeated errors, I am a newbie to nodejs community:)

I will fix other document errors later, and I know I can do make lint-md and make format-md locally, that's very
helpful, cool :)

nodejs-github-bot · 2024-03-25T12:42:48Z

Commit Queue failed

- Loading data for nodejs/node/pull/52179
✔  Done loading data for nodejs/node/pull/52179
----------------------------------- PR info ------------------------------------
Title      doc: add mold to speeding up section (#52179)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     congzhangzh:add_mold_to_speed_up_section -> nodejs:main
Labels     doc, build, commit-queue-squash
Commits    3
 - doc: add mold to speeding up section
 - doc: format-md for speeding up section
 - doc: fix lint-md failed
Committers 2
 - GitHub 
 - Cong Zhang <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/52179
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52179
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: fix lint-md failed
   ℹ  This PR was created on Thu, 21 Mar 2024 17:08:16 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52179#pullrequestreview-1956285442
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52179#pullrequestreview-1956294857
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8420226631

congzhangzh · 2024-03-25T15:01:28Z

@H4ad Hi Vinicius, the last commit 4 fix lint-md need to be approved before landing, tks:)

nodejs-github-bot · 2024-03-25T15:40:11Z

Landed in fc02918

anonrig · 2024-03-25T15:40:32Z

BUILDING.md

+brew install ccache mold       # see https://brew.sh
+export CC="ccache cc"          # add to ~/.zshrc or other shell config file
+export CXX="ccache c++"        # add to ~/.zshrc or other shell config file
+export LDFLAGS="-fuse-ld=mold" # add to ~/.zshrc or other shell config file


Support for Mach-O targets has been removed.
See https://github.com/bluewhalesystems/sold for macOS/iOS support.

I think we should use sold in macOS

@congzhangzh Are you willing to open a PR to replace mold to sold on mac?

Don't forget that sold is not available on homebrew

sure, please allow me do more test on mac os

@rui314 Hi Rui, is that ok we use sold in nodejs, as this mark on https://bluewhale.systems/ websit

What is the difference between sold and mold?
Other than the branding and their licenses, sold and mold behave the same. Both sold and mold are developed >> by us and our contributors.

btw, and whether mold merge all sold functions?

sold is not actively maintained anymore because with Xcode 15, Apple has made their linker much faster than it was. So you want to recommend it instead of sold. IIRC, the Apple's new linker is available as ld-prime after installing Xcode 15.

sold is not actively maintained anymore because with Xcode 15, Apple has made their linker much faster than it was. So you want to recommend it instead of sold. IIRC, the Apple's new linker is available as ld-prime after installing Xcode 15.

@rui314 @H4ad @anonrig Hi folks, can you help to ensure that the new linker ld-prime works, which point by Rui

Since Apple's linker is not my product, and I no longer working on macOS, I don't know whether that LDFLAGS works or not.

I don't have macos :/

Also, as mentioned by @anonrig, I think we should remove mold from macos section and don't use sold since is not maintained anymore.

ok, got it, I will do a pull request later:)

I don't have macos :/

Also, as mentioned by @anonrig, I think we should remove mold from macos section and don't use sold since is not maintained anymore.

@H4ad I create a merge request to fix it, #52252

PR-URL: nodejs#52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

PR-URL: #52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

doc: add mold to speeding up section

32cde82

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 21, 2024

congzhangzh mentioned this pull request Mar 21, 2024

[BUILDING.md] Update GNU/Linux Speeding up section #52116

Closed

congzhangzh closed this by deleting the head repository Mar 22, 2024

congzhangzh reopened this Mar 22, 2024

H4ad approved these changes Mar 23, 2024

View reviewed changes

doc: format-md for speeding up section

a128ec7

anonrig approved these changes Mar 23, 2024

View reviewed changes

doc: fix lint-md failed

90fe701

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 25, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 25, 2024

H4ad approved these changes Mar 25, 2024

View reviewed changes

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2024

nodejs-github-bot merged commit fc02918 into nodejs:main Mar 25, 2024
24 checks passed

anonrig reviewed Mar 25, 2024

View reviewed changes

anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024

doc: add mold to speeding up section

f123196

PR-URL: nodejs#52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024

doc: add mold to speeding up section

5786d9b

PR-URL: nodejs#52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

congzhangzh mentioned this pull request Mar 28, 2024

doc: remove mold use on mac for speeding up build #52252

Closed

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito pushed a commit that referenced this pull request May 2, 2024

doc: add mold to speeding up section

5ecf5b1

PR-URL: #52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

marco-ippolito pushed a commit that referenced this pull request May 3, 2024

doc: add mold to speeding up section

3d67b6b

PR-URL: #52179 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add mold to speeding up section #52179

doc: add mold to speeding up section #52179

congzhangzh commented Mar 21, 2024

congzhangzh commented Mar 21, 2024

H4ad commented Mar 22, 2024 •

edited

Loading

sxa commented Mar 22, 2024

congzhangzh commented Mar 22, 2024

H4ad commented Mar 23, 2024

congzhangzh commented Mar 23, 2024

congzhangzh commented Mar 23, 2024

nodejs-github-bot commented Mar 25, 2024

congzhangzh commented Mar 25, 2024 •

edited

Loading

nodejs-github-bot commented Mar 25, 2024

anonrig Mar 25, 2024

H4ad Mar 25, 2024

anonrig Mar 25, 2024

congzhangzh Mar 26, 2024

rui314 Mar 26, 2024

congzhangzh Mar 27, 2024

rui314 Mar 27, 2024

H4ad Mar 27, 2024

congzhangzh Mar 28, 2024 •

edited

Loading

congzhangzh Mar 28, 2024

doc: add mold to speeding up section #52179

doc: add mold to speeding up section #52179

Conversation

congzhangzh commented Mar 21, 2024

congzhangzh commented Mar 21, 2024

H4ad commented Mar 22, 2024 • edited Loading

sxa commented Mar 22, 2024

congzhangzh commented Mar 22, 2024

H4ad commented Mar 23, 2024

congzhangzh commented Mar 23, 2024

congzhangzh commented Mar 23, 2024

nodejs-github-bot commented Mar 25, 2024

congzhangzh commented Mar 25, 2024 • edited Loading

nodejs-github-bot commented Mar 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

congzhangzh Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

H4ad commented Mar 22, 2024 •

edited

Loading

congzhangzh commented Mar 25, 2024 •

edited

Loading

congzhangzh Mar 28, 2024 •

edited

Loading