Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: address coverity warning in module_wrap.cc #52143

Closed
wants to merge 2 commits into from
Closed

src: address coverity warning in module_wrap.cc #52143

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

  • remove copying as suggested by coverity

@mhdawson
src: address coverity warning in module_wrap.cc
ad295e2 
- remove copying as suggested by coverity

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 18, 2024
@mhdawson
Copy link
Member Author

Coverity warning:

130  if (env()->options()->warnings) {
     	
CID 352460: (#1 of 1): AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)
1. auto_causes_copy: Using the auto keyword without an & causes the copy of an object of type tuple.
     	Use auto & instead of auto.
131    for (auto pair : stalled) {
132      Local<v8::Message> message = std::get<1>(pair);
133
134      std::string reason = "Warning: Detected unsettled top-level await at ";
135      std::string info =
136          FormatErrorMessage(isolate, context, "", message, true);
137      reason += info;
138      FPrintF(stderr, "%s\n", reason);
139    }
140  }

@mhdawson
squash: make linter happy
075a3fc 
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57856/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57912/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57942/

mhdawson added a commit that referenced this pull request Mar 25, 2024
@mhdawson
src: address coverity warning in module_wrap.cc
681b0a3 
- remove copying as suggested by coverity

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52143
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 681b0a3

@mhdawson mhdawson closed this Mar 25, 2024
anonrig pushed a commit to anonrig/node that referenced this pull request Mar 25, 2024
@mhdawson @anonrig
src: address coverity warning in module_wrap.cc
7598315 
- remove copying as suggested by coverity

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52143
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@mhdawson @rdw-msft
src: address coverity warning in module_wrap.cc
939aa8d 
- remove copying as suggested by coverity

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52143
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
@marco-ippolito
Copy link
Member

This doesn't land cleanly on v20, requires a manual backport

@marco-ippolito marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhdawson @nodejs-github-bot @marco-ippolito @lpinca @legendecas