Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: emit diagnostics when watch mode drains #52130

Merged
merged 1 commit into from
Mar 19, 2024
Merged

test_runner: emit diagnostics when watch mode drains #52130

merged 1 commit into from
Mar 19, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Mar 17, 2024

Fixes: #51253

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 17, 2024
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57809/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57832/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57833/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit f9755f6 into nodejs:main Mar 19, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f9755f6

@MoLow MoLow deleted the test-runner-emit-diagnostics-when-drained branch March 26, 2024 08:51
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@MoLow @rdw-msft
test_runner: emit diagnostics when watch mode drains
ef34809 
PR-URL: nodejs#52130
Fixes: nodejs#51253
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@MoLow @marco-ippolito
test_runner: emit diagnostics when watch mode drains
b6bc245 
PR-URL: #52130
Fixes: #51253
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@MoLow @marco-ippolito
test_runner: emit diagnostics when watch mode drains
caec996 
PR-URL: #52130
Fixes: #51253
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_runner: add coverage support with watch mode.
4 participants
@MoLow @nodejs-github-bot @cjihrig @atlowChemi