crypto: fix input validation in crypto.hash

[aduh95]

The documentation was wrong as it was mentioning ArrayBuffer, and the error message was wrong as it wasn't mentioning string.

Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/57739/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/57770/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/52070
✔  Done loading data for nodejs/node/pull/52070
----------------------------------- PR info ------------------------------------
Title      crypto: fix `input` validation in `crypto.hash` (#52070)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:crypto-hash-input-validation -> nodejs:main
Labels     crypto, author ready, needs-ci
Commits    1
 - crypto: fix `input` validation in `crypto.hash`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/52070
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52070
Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 13 Mar 2024 10:43:24 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52070#pullrequestreview-1935501284
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52070#pullrequestreview-1940343564
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-15T20:05:29Z: https://ci.nodejs.org/job/node-test-pull-request/57770/
- Querying data for job/node-test-pull-request/57770/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52070
From https://github.com/nodejs/node
 * branch                  refs/pull/52070/merge -> FETCH_HEAD
✔  Fetched commits as 0a252c23d904..67bed235d4fb
--------------------------------------------------------------------------------
Auto-merging doc/api/crypto.md
[main f90feb8b5b] crypto: fix `input` validation in `crypto.hash`
 Author: Antoine du Hamel 
 Date: Wed Mar 13 11:39:22 2024 +0100
 1 file changed, 2 insertions(+), 3 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
crypto: fix `input` validation in `crypto.hash`
PR-URL: #52070

Fixes: https://github.com/nodejs/node/pull/51044/files#r1522362983

Reviewed-By: Vinícius Lourenço Claro Cardoso [email protected]

Reviewed-By: Luigi Pinca [email protected]
[main 1301154046] crypto: fix input validation in crypto.hash

Author: Antoine du Hamel [email protected]

Date: Wed Mar 13 11:39:22 2024 +0100

1 file changed, 2 insertions(+), 3 deletions(-)

✖  13011540468129074b6f4ee7ab6f2dc5f65cf4c9

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  2:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue

https://github.com/nodejs/node/actions/runs/8373759766

[aduh95]

Landed in 6dd1c75