Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: run before hook immediately if test started #52003

Merged
merged 2 commits into from
Mar 9, 2024
Merged

test_runner: run before hook immediately if test started #52003

merged 2 commits into from
Mar 9, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Mar 7, 2024

Fixes #51371

instead of the previous fix not running hooks when no tests,
this makes sure before and after hooks run regardless of the existence of subtests

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@MoLow MoLow requested review from cjihrig, atlowChemi and rluvaton March 7, 2024 13:11
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 7, 2024
rluvaton
rluvaton reviewed Mar 7, 2024
View reviewed changes
test/fixtures/test-runner/output/global-hooks-with-no-tests.snapshot
@@ -0,0 +1,12 @@
before
TAP version 13
Copy link
Member

@rluvaton rluvaton Mar 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but shouldn't tap version be called at the beginning of the output?

@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57613/

cjihrig
cjihrig approved these changes Mar 7, 2024
View reviewed changes
lib/internal/test_runner/harness.js Outdated Show resolved Hide resolved
@MoLow MoLow added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57624/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57625/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57627/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5d13419 into nodejs:main Mar 9, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5d13419

@MoLow MoLow deleted the test-runner-run-before-immidiatly branch March 9, 2024 21:03
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@MoLow @rdw-msft
test_runner: run before hook immediately if test started
fe3fa9d 
PR-URL: nodejs#52003
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@MoLow @marco-ippolito
test_runner: run before hook immediately if test started
a223ca4 
PR-URL: #52003
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
@MoLow @jcbhmr
test_runner: run before hook immediately if test started
15245c2 
PR-URL: nodejs#52003
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cjihrig cjihrig mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@rluvaton rluvaton rluvaton approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_runner: after() hook is called for no subtests
6 participants
@MoLow @nodejs-github-bot @benjamingr @cjihrig @rluvaton @atlowChemi