Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: return directly if udp socket close before lookup #51914

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/dgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {

// Resolve address first
state.handle.lookup(address, (err, ip) => {
if (!state.handle)
return; // Handle has been closed in the mean time

if (err) {
state.bindState = BIND_STATE_UNBOUND;
this.emit('error', err);
Expand Down Expand Up @@ -356,9 +359,6 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {
this.emit('error', ex);
});
} else {
if (!state.handle)
return; // Handle has been closed in the mean time

const err = state.handle.bind(ip, port || 0, flags);
if (err) {
const ex = new ExceptionWithHostPort(err, 'bind', ip, port);
Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-dgram-bind-socket-close-before-lookup.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';
const common = require('../common');
const dgram = require('dgram');

// Do not emit error event in callback which is called by lookup when socket is closed
const socket = dgram.createSocket({
theanarkh marked this conversation as resolved.
Show resolved Hide resolved
type: 'udp4',
lookup: (...args) => {
// Call lookup callback after 1s
setTimeout(() => {
args.at(-1)(new Error('an error'));
}, 1000);
}
});

socket.on('error', common.mustNotCall());
socket.bind(12345, 'localhost');
// Close the socket before calling DNS lookup callback
socket.close();