test_runner: add ref methods to mocked timers #51809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
marco-ippolito
force-pushed
the
feat/test-runner-mocks
branch
from
6979093 to
284e496
Compare
marco-ippolito
force-pushed
the
feat/test-runner-mocks
branch
from
284e496 to
9139eba
Compare
atlowChemi
approved these changes
Feb 20, 2024
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Feb 20, 2024
MoLow
added
the
author ready
marco-ippolito
force-pushed
the
feat/test-runner-mocks
branch
from
9139eba to
c87a2a2
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
rluvaton
reviewed
Feb 21, 2024
| @@ -844,4 +844,38 @@ describe('Mock Timers Test Suite', () => { | |||
| clearTimeout(id); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Api should have same public properties as original', () => { | |||
There was a problem hiding this comment.
What about adding tests that go over all properties so we won't have that problem again?
There was a problem hiding this comment.
Do you meanb internal mock properties that are not part of the original Timeout object?
|
please rebase to include #51834 |
marco-ippolito
force-pushed
the
feat/test-runner-mocks
branch
from
c87a2a2 to
ce96e7d
Compare
MoLow
approved these changes
Feb 26, 2024
github-actions
bot
removed
the
request-ci
bnb
approved these changes
Feb 26, 2024
mertcanaltin
approved these changes
Feb 26, 2024
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6cb8a60 |
marco-ippolito
added a commit
that referenced
this pull request
Feb 27, 2024
Fixes: #51701 PR-URL: #51809 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fixes: #51701 PR-URL: #51809 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fixes: #51701 PR-URL: #51809 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Fixes: nodejs#51701 PR-URL: nodejs#51809 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51701
It adds properties
ref,unref,refresh,hasRefto mock timers for compatibility.