Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: improve eventEmitter.once() performance #5127

Closed
wants to merge 1 commit into from
Closed

events: improve eventEmitter.once() performance #5127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions benchmark/events/ee-add-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
'use strict';

var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [50e6]
});

function main(conf) {
var n = +conf.n;
var ee = new EventEmitter();
var listeners = [];

var k;
for (k = 0; k < 10; k += 1)
listeners.push(function() {});

// Force optimization before starting the benchmark
ee.once('dummy', listeners[0]);
ee._events = {};
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.once)');
ee.once('dummy', listeners[0]);
ee._events = {};

bench.start();
for (var i = 0; i < n; ++i) {
for (k = listeners.length; --k >= 0; /* empty */)
ee.once('dummy', listeners[k]);
ee._events = {};
}
bench.end(n);
}
41 changes: 41 additions & 0 deletions benchmark/events/ee-add-remove-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
'use strict';

var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [25e6]
});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();
var listeners = [];

var k;
for (k = 0; k < 10; k += 1)
listeners.push(function() {});

for (k = listeners.length; --k >= 0; /* empty */)
ee.once('dummy', listeners[k]);
for (k = listeners.length; --k >= 0; /* empty */)
ee.removeListener('dummy', listeners[k]);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.once)');
eval('%OptimizeFunctionOnNextCall(ee.removeListener)');
for (k = listeners.length; --k >= 0; /* empty */)
ee.once('dummy', listeners[k]);
for (k = listeners.length; --k >= 0; /* empty */)
ee.removeListener('dummy', listeners[k]);

bench.start();
for (var i = 0; i < n; i += 1) {
for (k = listeners.length; --k >= 0; /* empty */)
ee.once('dummy', listeners[k]);
for (k = listeners.length; --k >= 0; /* empty */)
ee.removeListener('dummy', listeners[k]);
}
bench.end(n);
}
24 changes: 20 additions & 4 deletions benchmark/events/ee-add-remove.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,35 @@
'use strict';
var common = require('../common.js');
var events = require('events');

var bench = common.createBenchmark(main, {n: [25e4]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [50e5]
});

function main(conf) {
var n = conf.n | 0;

var ee = new events.EventEmitter();
var ee = new EventEmitter();
var listeners = [];

var k;
for (k = 0; k < 10; k += 1)
listeners.push(function() {});

for (k = listeners.length; --k >= 0; /* empty */)
ee.on('dummy', listeners[k]);
for (k = listeners.length; --k >= 0; /* empty */)
ee.removeListener('dummy', listeners[k]);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.on)');
eval('%OptimizeFunctionOnNextCall(ee.removeListener)');
for (k = listeners.length; --k >= 0; /* empty */)
ee.on('dummy', listeners[k]);
for (k = listeners.length; --k >= 0; /* empty */)
ee.removeListener('dummy', listeners[k]);

bench.start();
for (var i = 0; i < n; i += 1) {
for (k = listeners.length; --k >= 0; /* empty */)
Expand Down
35 changes: 35 additions & 0 deletions benchmark/events/ee-add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
'use strict';

var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [100e5]
});

function main(conf) {
var n = +conf.n;
var ee = new EventEmitter();
var listeners = [];

var k;
for (k = 0; k < 10; k += 1)
listeners.push(function() {});

// Force optimization before starting the benchmark
ee.on('dummy', listeners[0]);
ee._events = {};
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.on)');
ee.on('dummy', listeners[0]);
ee._events = {};

bench.start();
for (var i = 0; i < n; ++i) {
for (k = listeners.length; --k >= 0; /* empty */)
ee.on('dummy', listeners[k]);
ee._events = {};
}
bench.end(n);
}
15 changes: 12 additions & 3 deletions benchmark/events/ee-emit-multi-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict';
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e6]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [25e6]
});

function main(conf) {
var n = conf.n | 0;
Expand All @@ -12,6 +16,11 @@ function main(conf) {
for (var k = 0; k < 10; k += 1)
ee.on('dummy', function() {});

ee.emit('dummy', 5, true);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.emit)');
ee.emit('dummy', 5, true);

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy', 5, true);
Expand Down
32 changes: 32 additions & 0 deletions benchmark/events/ee-emit-once.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict';

var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [25e6]
});

function main(conf) {
var n = conf.n | 0;

var ee = new EventEmitter();

function noop() {}

ee.once('dummy', noop);
ee.emit('dummy');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.once)');
eval('%OptimizeFunctionOnNextCall(ee.emit)');
ee.once('dummy', noop);
ee.emit('dummy');

bench.start();
for (var i = 0; i < n; i += 1) {
ee.once('dummy', noop);
ee.emit('dummy');
}
bench.end(n);
}
15 changes: 12 additions & 3 deletions benchmark/events/ee-emit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict';
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [2e6]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [50e6]
});

function main(conf) {
var n = conf.n | 0;
Expand All @@ -12,6 +16,11 @@ function main(conf) {
for (var k = 0; k < 10; k += 1)
ee.on('dummy', function() {});

ee.emit('dummy');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.emit)');
ee.emit('dummy');

bench.start();
for (var i = 0; i < n; i += 1) {
ee.emit('dummy');
Expand Down
15 changes: 12 additions & 3 deletions benchmark/events/ee-listener-count-on-prototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict';
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [5e7]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [5e7]
});

function main(conf) {
var n = conf.n | 0;
Expand All @@ -12,6 +16,11 @@ function main(conf) {
for (var k = 0; k < 10; k += 1)
ee.on('dummy', function() {});

ee.listenerCount('dummy');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.listenerCount)');
ee.listenerCount('dummy');

bench.start();
for (var i = 0; i < n; i += 1) {
ee.listenerCount('dummy');
Expand Down
15 changes: 12 additions & 3 deletions benchmark/events/ee-listeners-many.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict';
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [5e6]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [15e6]
});

function main(conf) {
var n = conf.n | 0;
Expand All @@ -13,6 +17,11 @@ function main(conf) {
for (var k = 0; k < 100; k += 1)
ee.on('dummy', function() {});

ee.listeners('dummy');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.listeners)');
ee.listeners('dummy');

bench.start();
for (var i = 0; i < n; i += 1) {
ee.listeners('dummy');
Expand Down
15 changes: 12 additions & 3 deletions benchmark/events/ee-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
'use strict';
var common = require('../common.js');
var EventEmitter = require('events').EventEmitter;

var bench = common.createBenchmark(main, {n: [5e6]});
var common = require('../common');
var EventEmitter = require('events');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
n: [90e6]
});

function main(conf) {
var n = conf.n | 0;
Expand All @@ -12,6 +16,11 @@ function main(conf) {
for (var k = 0; k < 10; k += 1)
ee.on('dummy', function() {});

ee.listeners('dummy');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(ee.listeners)');
ee.listeners('dummy');

bench.start();
for (var i = 0; i < n; i += 1) {
ee.listeners('dummy');
Expand Down
Loading