Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: improve OpenSSL initialization #51019

Closed
wants to merge 1 commit into from
Closed

crypto: improve OpenSSL initialization #51019

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 2, 2023 •
edited
Loading

  • Use OPENSSL_INIT_ADD_ALL_DIGESTS to speed up digest lookup.

Refs: nodejs/performance#136

@joyeecheung
crypto: improve OpenSSL initialization
6380981 
- Use OPENSSL_INIT_ADD_ALL_DIGESTS to speed up digest lookup.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 2, 2023
@joyeecheung joyeecheung mentioned this pull request Dec 2, 2023
Closed
anonrig
anonrig approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 2, 2023
mcollina
mcollina approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56047/

@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 2, 2023 •
edited
Loading

Oops, I think I made a mistake, the numbers were from the build of #51017, and I was comparing that build with main. This PR does not make a performance difference (while apparently the other one does). Though the idea essentially is trying to avoid the cost of repeated digest lookup, which maybe done differently. It also looks like EVP_get_digestbyname would already initialize OpenSSL with OPENSSL_INIT_ADD_ALL_DIGESTS, so we don't need to do that here.

@joyeecheung joyeecheung closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeecheung @nodejs-github-bot @mcollina @anonrig