Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 5.28.1 #50975

Merged
merged 1 commit into from
Dec 2, 2023
Merged

deps: update undici to 5.28.1 #50975

merged 1 commit into from
Dec 2, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of undici to 5.28.1.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 30, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56015/

@panva
Copy link
Member

panva commented Nov 30, 2023

cc @nodejs/undici

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2023
mcollina
mcollina approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 78855fd into main Dec 2, 2023
66 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 78855fd

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch December 2, 2023 14:38
targos pushed a commit that referenced this pull request Dec 4, 2023
@nodejs-github-bot @targos
deps: update undici to 5.28.1
099ebdb 
PR-URL: #50975
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@targos targos mentioned this pull request Dec 4, 2023
Merged
@richardlau richardlau added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 25, 2024
@richardlau
Copy link
Member

dont-land-on-v20.x as undici was updated past this version there for a recent security release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@panva panva panva approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodejs-github-bot @panva @richardlau @mcollina @metcoder95 @marco-ippolito @KhafraDev