Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use requires instead of flaky in console WPT status #50812

Merged
merged 1 commit into from
Nov 21, 2023
Merged

test: use requires instead of flaky in console WPT status #50812

merged 1 commit into from
Nov 21, 2023

Conversation

panva
Copy link
Member

@panva panva commented Nov 19, 2023

These tests are not flaky, they just have requirements, see #44185 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 19, 2023
@panva panva added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55753/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55757/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2e33b16 into nodejs:main Nov 21, 2023
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2e33b16

@panva panva deleted the wpt-no-flaky branch November 21, 2023 09:22
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
test: use requires instead of flaky in console WPT status
6a30eda 
PR-URL: #50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva @martenrichter
test: use requires instead of flaky in console WPT status
7ab0a68 
PR-URL: nodejs#50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
test: use requires instead of flaky in console WPT status
478d646 
PR-URL: nodejs#50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva @RafaelGSS
test: use requires instead of flaky in console WPT status
0e4d25e 
PR-URL: #50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva @RafaelGSS
test: use requires instead of flaky in console WPT status
abbc312 
PR-URL: #50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@panva @UlisesGascon
test: use requires instead of flaky in console WPT status
47e4ea0 
PR-URL: #50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
@panva panva added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Dec 15, 2023
@panva
Copy link
Member Author

panva commented Dec 15, 2023

Depends on #50631 for backporting.

sapphi-red pushed a commit to sapphi-red/node that referenced this pull request Mar 26, 2024
@panva @sapphi-red
test: use requires instead of flaky in console WPT status
c16cfb7 
PR-URL: nodejs#50812
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @jasnell @anonrig