doc: document non-node_modules-only runtime deprecation #50748
Conversation
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.
nodejs-github-bot
added
deprecations
|
cc @nodejs/tsc |
I didn't even know this possibility existed. There are many modules features where we would want such a "my code only" warning. |
The reason why we had this case was because Buffer constructor was too widely used so that we had many complaints from users after emitting the warnings by default and it encouraged disabling warnings (especially for CLIs that spawn child processes). I am fairly certain that this would happen again soon, looking at our recent deprecation discussions. |
|
There is a typo in commit message. runtiem -> runtime. |
Co-authored-by: Geoffrey Booth <[email protected]>
Co-authored-by: Geoffrey Booth <[email protected]>
Co-authored-by: Chengzhong Wu <[email protected]>
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3ffe2e8 |
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately. PR-URL: #50748 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.