Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for of #50602

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test: replace forEach with for of #50602

merged 1 commit into from
Nov 10, 2023

Conversation

john-mcinall
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@ljharb
Copy link
Member

ljharb commented Nov 7, 2023

for-of is more brittle than forEach; why this change?

@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@RafaelGSS
Copy link
Member

for-of is more brittle than forEach; why this change?

This is for a workshop we're running at NodeConf. See the code-and-learn label.

RafaelGSS
RafaelGSS approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb
Copy link
Member

ljharb commented Nov 7, 2023

Alrighty; it’d still be good to have a justification provided :-)

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55485/

@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55494/

@benjamingr
Copy link
Member

for-of is more brittle than forEach; why this change?

Note this is a test file so that shouldn't be a concern

@ljharb
Copy link
Member

ljharb commented Nov 8, 2023

I totally agree; I’m just surprised that a learning exercise doesn’t include instructions to provide a justification.

@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55521/

@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Open
18 tasks
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit fd4a305 into nodejs:main Nov 10, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fd4a305

@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@john-mcinall @targos
test: replace forEach with for of
8c97a80 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@john-mcinall @targos
test: replace forEach with for of
864cd32 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@john-mcinall @UlisesGascon
test: replace forEach with for of
9f911d3 
PR-URL: #50602
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@john-mcinall @nodejs-github-bot @ljharb @RafaelGSS @benjamingr @lpinca @marco-ippolito