Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: set test-esm-loader-resolve-type as flaky" #50315

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Revert "test: set test-esm-loader-resolve-type as flaky" #50315

merged 1 commit into from
Oct 21, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 21, 2023

Reverts #50226 because #50273 has landed

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 21, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 21, 2023

Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/461/

Uzlopak
Uzlopak approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 21, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55083/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55084/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55091/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 745979c into main Oct 21, 2023
41 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 745979c

@nodejs-github-bot nodejs-github-bot deleted the revert-50226-set-esm-loader-flaky branch October 21, 2023 15:54
This was referenced Oct 22, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@aduh95 @targos
Revert "test: set test-esm-loader-resolve-type as flaky"
7f87084 
This reverts commit 2e4bb3c.

PR-URL: #50315
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Open
27 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
Revert "test: set test-esm-loader-resolve-type as flaky"
ef8c1eb 
This reverts commit 2e4bb3c.

PR-URL: nodejs#50315
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Nov 11, 2023
targos pushed a commit that referenced this pull request Nov 11, 2023
@aduh95 @targos
Revert "test: set test-esm-loader-resolve-type as flaky"
3d9130b 
This reverts commit 2e4bb3c.

PR-URL: #50315
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @panva @lpinca @anonrig @Uzlopak @H4ad @targos