doc: explain how to disable navigator
#50310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyBooth
added
doc
anonrig
approved these changes
Oct 20, 2023
himself65
approved these changes
Oct 21, 2023
GeoffreyBooth
added
the
author ready
|
Landing should wait until a decision has been made on whether or not to keep navigator around (IOW, blocked on #50269.) |
No. We can always land this and remove the API. |
MoLow
approved these changes
Oct 21, 2023
GeoffreyBooth
added
the
commit-queue
29 tasks
nodejs-github-bot
removed
the
commit-queue
|
Landed in 25576b5 |
26 tasks
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50310 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
27 tasks
|
cc @nodejs/web-standards since we weren't given a chance to weigh in before node's docs recommended a decades-old bad practice. |
|
Another issue with this recommendation if that |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50310 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #50269 (comment), this adds a note about how to delete the
navigatorglobal if necessary. This also sets the experimental status level.