Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove internal mime fns from benchmarks #50201

Merged
merged 1 commit into from
Oct 21, 2023
Merged

util: remove internal mime fns from benchmarks #50201

merged 1 commit into from
Oct 21, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 16, 2023

As discussed in @nodejs/performance meeting, benchmarks should be only benching user facing api.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 16, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 16, 2023

@anonrig
@RafaelGSS

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54856/

RafaelGSS
RafaelGSS approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we'll need to bench internal functions, but that's not the case. LGTM.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 17, 2023

@RafaelGSS
Can you please retrigger the ci?
This PR should actually not have any effects on the CI.

@H4ad H4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54911/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54967/

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Open
25 tasks
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 21, 2023

@anonrig
@H4ad
@aduh95
@RafaelGSS

can this please be merged?

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 2e5ffe9 into nodejs:main Oct 21, 2023
35 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2e5ffe9

@Uzlopak Uzlopak deleted the remove-internal-mime-fn-from-benchmark branch October 21, 2023 02:34
targos pushed a commit that referenced this pull request Oct 23, 2023
@Uzlopak @targos
util: remove internal mime fns from benchmarks
5dc454a 
PR-URL: #50201
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@Uzlopak @alexfernandez
util: remove internal mime fns from benchmarks
e002ace 
PR-URL: nodejs#50201
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak @targos
util: remove internal mime fns from benchmarks
bf5b211 
PR-URL: #50201
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@H4ad H4ad H4ad approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Uzlopak @nodejs-github-bot @anonrig @H4ad @RafaelGSS