Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: name scoped lock #50010

Merged
merged 1 commit into from
Oct 4, 2023
Merged

src: name scoped lock #50010

merged 1 commit into from
Oct 4, 2023

Conversation

VoltrexKeyva
Copy link
Member

Name a scoped lock to be consistent with all the others.

@VoltrexKeyva
src: name scoped lock
f34f9a2 
Name a scoped lock to be consistent with all the others.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 2, 2023
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54477/

@VoltrexKeyva VoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2023
@VoltrexKeyva VoltrexKeyva added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 55ff640 into nodejs:main Oct 4, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 55ff640

@VoltrexKeyva VoltrexKeyva deleted the name-scopedlock branch October 4, 2023 14:42
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@VoltrexKeyva @alexfernandez
src: name scoped lock
40d0319 
Name a scoped lock to be consistent with all the others.

PR-URL: nodejs#50010
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@VoltrexKeyva @targos
src: name scoped lock
1eb2af2 
Name a scoped lock to be consistent with all the others.

PR-URL: #50010
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@VoltrexKeyva @debadree25
src: name scoped lock
d1b03e0 
Name a scoped lock to be consistent with all the others.

PR-URL: nodejs#50010
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VoltrexKeyva @nodejs-github-bot @bnoordhuis @tniessen