src: add GetValidatedFd() to node_file
#49903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
pluris
changed the title
GetValidatedFd() in node_fileGetValidatedFd() to node_file
pluris
force-pushed
the
feat/get_validated_fd
branch
from
ed908e6 to
b35894e
Compare
|
I think we should only be adding code that is currently used somewhere. I get you have other PRs that use this function, but it would be better to just wait for one of them to land first and then rebase the other. |
|
@mscdex |
|
Hey @pluris, Are you working on this? I'd like to continue on the work on |
|
@anonrig No, I'm not working on it. I think it would be better for you to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function to validate file descriptor in c++ land has been added.
This is a C++ implementation of
getValidatedFd()in js.Refs: #49898, #49880