perf_hooks: reduce overhead of new performance_entries

[H4ad]

Continuing the work started on nodejs/performance#109

Removed two references for ReflectConstruct, the improvements for createPerformanceNodeEntry can be seen using the timerfied function:

                                                    confidence improvement accuracy (*)    (**)   (***)
perf_hooks/timerfied.js observe='function' n=100000        ***    872.44 %      ±22.56% ±30.40% ±40.36%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

The createPerformanceEntry is not used, should I remove it?

/cc @nodejs/performance

[H4ad]

@jasnell Do you have any reason to add ERR_ILLEGAL_CONSTRUCTOR for PerformanceEntry?

I saw the PerformanceMark without it, so maybe we could remove it from this class too, it will simplify this a lot this code.

[mcollina]

lgtm

[Uzlopak]

impressive

[benjamingr]

oh wow we were passing a new constructor each time?

This is a subtly breaking change (if someone relied on them having different constructors) but I think we never made that commitment so this is fine to me as minor/patch

gj

[anonrig]

🚀

[H4ad]

Sorry for the force-push but I read another PR of @rluvaton, this new way is a faster (793%->872%) and cleaner way to do the same thing.

[Qard]

LGTM. Out of curiosity though, with the skip throw thing in the constructor, can the perf be improved even further by putting the init behaviour directly in the constructor after the skipped throw?

[H4ad]

@Qard, I need to try, but it may not change significantly as it will be essentially the same operations.

Also, I don't know if there is any spec compliance with the constructor I avoid changing the arguments of the Performance Entry, without = undefined, it breaks the webidl tests.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54218/

[H4ad]

Is there something I can do about the failing checks?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54270/

[Uzlopak]

@anonrig has to start them over and over again, till they are green :P

[nodejs-github-bot]

Landed in a6ad048