-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use destructuring in test-path-parse-format #49790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 22, 2023
tniessen
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @gibbyfree.
tniessen
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Sep 22, 2023
tniessen
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 22, 2023
20 tasks
lpinca
approved these changes
Sep 25, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 25, 2023
This was referenced Sep 27, 2023
ruyadorno
approved these changes
Sep 29, 2023
RafaelGSS
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 7, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 7, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 24, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 29, 2023
aduh95
approved these changes
May 11, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
May 11, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 11, 2024
Landed in 33370ee |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#49790 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.