Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable #49665

Merged
merged 1 commit into from
Sep 17, 2023
Merged

src: remove unused variable #49665

merged 1 commit into from
Sep 17, 2023

Conversation

targos
Copy link
Member

@targos targos commented Sep 15, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 15, 2023
@targos
Copy link
Member Author

targos commented Sep 15, 2023

Not sure why it wasn't failing elsewhere. I'm opening this because of https://github.com/nodejs/node/actions/runs/6198046200/job/16827755271

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53970/

@github-actions github-actions bot mentioned this pull request Sep 16, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53975/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 16, 2023
@github-actions github-actions bot mentioned this pull request Sep 17, 2023
Open
32 tasks
GeoffreyBooth
GeoffreyBooth approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs like this are my favorite PRs.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 36ab510 into nodejs:main Sep 17, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 36ab510

This was referenced Sep 18, 2023
Open
Open
@ruyadorno
Copy link
Member

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

@ruyadorno ruyadorno added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Sep 28, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@targos @alexfernandez
src: remove unused variable
52124e5 
PR-URL: nodejs#49665
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
src: remove unused variable
5a2351d 
PR-URL: #49665
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@targos targos deleted the unused-var branch November 12, 2023 10:47
@targos targos removed the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Nov 12, 2023
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @ruyadorno @jasnell @GeoffreyBooth @lpinca @UlisesGascon @richardlau @aduh95