Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: refactor globalPreload tests #49493

Closed
wants to merge 2 commits into from
Closed

esm: refactor globalPreload tests #49493

wants to merge 2 commits into from

Conversation

GeoffreyBooth
Copy link
Member

Similar to #49465 and supporting #49144, this PR refactors two tests that currently use the module customization hook globalPreload to use its replacement register / initialize instead. This spins off work from #49144 into a standalone PR so that we have examples to direct people to to show how they can do similar refactors. In that vein, after discussion with @aduh95 we would like to land this PR as two distinct commits, so that we can share either the link to this PR (to cite both tests) or the links to the two commits to reference one refactored test or the other. @nodejs/loaders

@GeoffreyBooth GeoffreyBooth added test Issues and PRs related to the tests. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Sep 4, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 4, 2023
@GeoffreyBooth GeoffreyBooth force-pushed the refactor-globalpreload-tests branch from 58636f2 to dcecdcf Compare September 4, 2023 22:34
@GeoffreyBooth GeoffreyBooth force-pushed the refactor-globalpreload-tests branch 2 times, most recently from 9b0614e to cef85dc Compare September 5, 2023 18:24
JakobJingleheimer
JakobJingleheimer approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

test/es-module/test-esm-loader-resolve-type.mjs Outdated Show resolved Hide resolved
test/fixtures/es-module-loaders/builtin-named-exports.mjs Outdated Show resolved Hide resolved
test/fixtures/es-module-loaders/hook-resolve-type-loader.mjs Show resolved Hide resolved
@GeoffreyBooth GeoffreyBooth force-pushed the refactor-globalpreload-tests branch from cef85dc to 7b3dfaf Compare September 5, 2023 20:49
@GeoffreyBooth GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53748/

@GeoffreyBooth GeoffreyBooth force-pushed the refactor-globalpreload-tests branch from 7b3dfaf to e5470e0 Compare September 5, 2023 20:56
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53749/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53750/

@nodejs nodejs deleted a comment from nodejs-github-bot Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53752/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53753/

@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Open
25 tasks
@GeoffreyBooth GeoffreyBooth added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 6, 2023
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 6, 2023
Merged
@JakobJingleheimer JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53758/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6b135a1...63c3846

nodejs-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@GeoffreyBooth @nodejs-github-bot
esm: refactor test-esm-named-exports
a927ade 
PR-URL: #49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@GeoffreyBooth @nodejs-github-bot
esm: refactor test-esm-loader-resolve-type
63c3846 
PR-URL: #49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@GeoffreyBooth GeoffreyBooth deleted the refactor-globalpreload-tests branch September 6, 2023 22:31
This was referenced Sep 7, 2023
Open
Open
Open
Open
@JakobJingleheimer JakobJingleheimer mentioned this pull request Sep 13, 2023
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@GeoffreyBooth @ruyadorno
esm: refactor test-esm-named-exports
17823b3 
PR-URL: #49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@GeoffreyBooth @ruyadorno
esm: refactor test-esm-loader-resolve-type
e74a075 
PR-URL: #49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 22, 2023
Closed
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@GeoffreyBooth @alexfernandez
esm: refactor test-esm-named-exports
1d235c8 
PR-URL: nodejs#49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@GeoffreyBooth @alexfernandez
esm: refactor test-esm-loader-resolve-type
79ea84c 
PR-URL: nodejs#49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth @targos
esm: refactor test-esm-named-exports
d785f83 
PR-URL: nodejs#49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth @targos
esm: refactor test-esm-loader-resolve-type
9a7a8c5 
PR-URL: nodejs#49493
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@GeoffreyBooth @targos
esm: refactor test-esm-named-exports
9b7c9d9 
PR-URL: #49493
Backport-PR-URL: #50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
@GeoffreyBooth @targos
esm: refactor test-esm-loader-resolve-type
0875867 
PR-URL: #49493
Backport-PR-URL: #50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: refactor test-esm-named-exports
64bbde6 
PR-URL: nodejs/node#49493
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: refactor test-esm-loader-resolve-type
fe729ec 
PR-URL: nodejs/node#49493
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: refactor test-esm-named-exports
63f4688 
PR-URL: nodejs/node#49493
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: refactor test-esm-loader-resolve-type
f60231d 
PR-URL: nodejs/node#49493
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GeoffreyBooth @nodejs-github-bot @JakobJingleheimer @aduh95 @targos