Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: revert IS_RELEASE to 0 #49084

Merged
merged 1 commit into from
Aug 10, 2023
Merged

src: revert IS_RELEASE to 0 #49084

merged 1 commit into from
Aug 10, 2023

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Aug 9, 2023 •
edited
Loading

The steps from https://github.com/nodejs/node/blob/main/doc/contributing/releases.md aren't working fine when dealing with multiple releases

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@mscdex
Copy link
Contributor

mscdex commented Aug 9, 2023

This has happened 4 times in the last year alone. Can we correct the documentation or somehow highlight the importance of making sure the flag is set back to 0 after a release?

@tniessen
Copy link
Member

tniessen commented Aug 9, 2023

cc @nodejs/releasers

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Aug 9, 2023 •
edited
Loading

cc @nodejs/releasers

We're discussing it on nodejs release channel. Basically, when no conflicts happen when https://github.com/nodejs/node/blob/main/doc/contributing/releases.md#13-cherry-pick-the-release-commit-to-main we should remember to manually revert the flag.

We can, possibly, change the command to include a sed or perl command to revert it.

@RafaelGSS
Copy link
Member Author

I'd like to propose that we just land this and don't wait for CI since all the changes are a single bit flip that will itself unbreak CI

@atlowChemi atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53101/

@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Aug 10, 2023
@aduh95 aduh95 merged commit 23d65e7 into main Aug 10, 2023
@aduh95 aduh95 deleted the RafaelGSS-patch-1 branch August 10, 2023 10:17
@aduh95
Copy link
Contributor

aduh95 commented Aug 10, 2023

Landed in 23d65e7

@RafaelGSS RafaelGSS mentioned this pull request Aug 11, 2023
Merged
martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@RafaelGSS @martenrichter
src: revert IS_RELEASE to 0
c9e0cfc 
PR-URL: nodejs#49084
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Aug 14, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE to 0
a763045 
PR-URL: nodejs#49084
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE to 0
4f240d7 
PR-URL: nodejs#49084
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RafaelGSS @mscdex @tniessen @nodejs-github-bot @aduh95 @benjamingr @richardlau @LiviaMedeiros @atlowChemi