-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix building when there is only python3 #48462
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks all CI. I also have this changes on my macOS too.
The error is:
|
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5295843320 |
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5298312237 |
broken on windows arm64 cc @nodejs/platform-arm @StefanStojanovic 11:04:03 'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:03 operable program or batch file.
11:04:03 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'out\Release\\node_js2c_host.exe;src\inspector\node_protocol.pdl;src\inspector\node_protocol_config.json;deps\v8\include\js_protocol.pdl;out\Release\\obj\global_intermediate\concatenated_protocol.json;deps\openssl\openssl\util\libcrypto.num' exited with code 1. [C:\workspace\node-compile-windows\node\libnode.vcxproj]
11:04:03 gen-regexp-special-case.cc
11:04:03 C:\workspace\node-compile-windows\node\deps\v8\src\base\bits.h(448,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\gen-regexp-special-case_host.vcxproj]
11:04:04 Creating library ..\..\out\Release\gen-regexp-special-case_host.lib and object ..\..\out\Release\gen-regexp-special-case_host.exp
11:04:04 gen-regexp-special-case_host.vcxproj -> ..\..\out\Release\\gen-regexp-special-case_host.exe
11:04:05 run_gen-regexp-special-case_action
11:04:05 'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:05 operable program or batch file.
11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case.vcxproj]
11:04:05 run_gen-regexp-special-case_action
11:04:05 'C:\Python310\python_host.exe' is not recognized as an internal or external command,
11:04:05 operable program or batch file.
11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case_host.vcxproj]
11:04:05
11:04:05 > if errorlevel 1 (
11:04:05 if not defined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen" |
@gengjiawen Can you trigger CI again? I don't have permission to add issue label. |
Commit Queue failed- Loading data for nodejs/node/pull/48462 ✔ Done loading data for nodejs/node/pull/48462 ----------------------------------- PR info ------------------------------------ Title build: fix building when there is only python3 (#48462) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:patch-8 -> nodejs:main Labels v8 engine, tools, needs-ci, commit-queue-squash Commits 5 - build: fix building when there is only python3 - build: always set 'python' variable when running GYP - build: add quotes when executing binary - build: work around gyp hack for win arm64 - gyp: add quotes for action's executable Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/48462 Reviewed-By: Luigi Pinca Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48462 Reviewed-By: Luigi Pinca Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix building when there is only python3 ⚠ - build: always set 'python' variable when running GYP ⚠ - build: add quotes when executing binary ⚠ - build: work around gyp hack for win arm64 ⚠ - gyp: add quotes for action's executable ℹ This PR was created on Thu, 15 Jun 2023 02:04:04 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48462#pullrequestreview-1482098764 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/48462#pullrequestreview-1575981535 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-24T11:34:56Z: https://ci.nodejs.org/job/node-test-pull-request/55180/ - Querying data for job/node-test-pull-request/55180/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6626587515 |
@@ -438,6 +438,7 @@ def _BuildCommandLineForRuleRaw( | |||
# Support a mode for using cmd directly. | |||
# Convert any paths to native form (first element is used directly). | |||
# TODO(quote): regularize quoting path names throughout the module | |||
command[1] = '"%s"' % command[1] | |||
arguments = ['"%s"' % i for i in arguments] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also upstream to https://github.com/nodejs/gyp-next
Landed in d1ccca9 |
PR-URL: nodejs#48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: nodejs/node#48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
On some environments, especially macOS, there is only
python3
and nopython
, replacing thepython
to<(python)
can make gyp use the correct python.