test_runner: remove redundant check from coverage #48070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
I am not sure I understand why this is redundant |
aduh95
reviewed
May 19, 2023
lib/internal/test_runner/coverage.js
Outdated
Comment on lines
381
to
387
| if (StringPrototypeIncludes(url, '/node_modules/') || | ||
| // On Windows some generated coverages are invalid. | ||
| !StringPrototypeStartsWith(url, 'file:')) { |
There was a problem hiding this comment.
Should we start with the file: check so core modules can still skip the /node_modules/ check? I suggest we also remove the comment which looks a bit out of place/context.
Suggested change
| if (StringPrototypeIncludes(url, '/node_modules/') || | |
| // On Windows some generated coverages are invalid. | |
| !StringPrototypeStartsWith(url, 'file:')) { | |
| if (!StringPrototypeStartsWith(url, 'file:') || StringPrototypeIncludes(url, '/node_modules/')) { |
There was a problem hiding this comment.
I'll remove the comment. I think having the node_modules check first will be more beneficial in real world apps where the node_modules directory makes up the bulk of the app.
There was a problem hiding this comment.
That's fair, maybe add a comment explaining the order was chosen purposefully and why
All of the valid coverages should start with |
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'.
19 tasks
aduh95
approved these changes
May 27, 2023
20 tasks
MoLow
approved these changes
May 28, 2023
MoLow
added
the
author ready
22 tasks
debadree25
approved these changes
May 29, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b47fce0 |
23 tasks
targos
pushed a commit
that referenced
this pull request
May 30, 2023
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: #48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
This was referenced May 31, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: #48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: nodejs#48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: nodejs#48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: nodejs#48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'.