build: add action to close stale PRs #48051
Conversation
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
We currently have over 195 pull requests which were created more than a year ago and (up from 117 a year ago). Most of those have not had an update/comments for over 6 months. This PR adds an action which will mark pull requests older than 1 year as stale once there have been no comments/updates for 5 months and then close them after another month if that does not trigger any comments. I think this will help us lower the backlog of PRs (430 right) now) and in particular by helping close those which are very unlikely to land. A simple comment is all it takes to reset the PR so that it won't be closed if that is the right thing to do. I had to add a new option to actions/stale to support the 1 year old check (end date - actions/stale#1013) so this uses my version of that action until we get the updated landed in actions/stale. The current action also requires PRs to be tagged with the Once all PRs that are currently stale are processed I'll then remove the requirement for that lable in a follow on PR and we will be at steady state where PRs get processed as they reach the 1year old and 6 months without any updates point. |
Co-authored-by: mscdex <[email protected]>
Co-authored-by: mscdex <[email protected]>
Co-authored-by: mscdex <[email protected]>
|
Can this be a modification of |
|
@Trott testing actions is a bit difficult and I'd be a bit worried that by combining in I might break the existing action or cause issues we don't want to be processed covered. If we want to consolidate then maybe we can do that as a follow on step as we already have more than one action handling stale issues. |
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
|
@nodejs/tsc FYI that I plan to land this in the next day or so unless there are comments/objections. |
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: #42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48051 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 65be890 |
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: #42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48051 Reviewed-By: Matteo Collina <[email protected]>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: #42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48051 Reviewed-By: Matteo Collina <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <[email protected]>
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48196 Reviewed-By: Mestery <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months. Fixes: nodejs#42981 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48051 Reviewed-By: Matteo Collina <[email protected]>
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48196 Reviewed-By: Mestery <[email protected]>
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
Add action to close PRs that are over 1 year old and have had no comments or updates in the last 6 months.
Fixes: #42981