-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update list of personal traits in CoC #4801
Conversation
cc @Charlotteis |
@sup yes, that is perfectly valid in English. |
@@ -4,8 +4,10 @@ This Code of Conduct is adapted from [Rust's wonderful | |||
CoC](http://www.rust-lang.org/conduct.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Rust adapted this from the Contributor Covenant so that might be worth including in the first sentence about adaptations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
I think it works how it is, yeah. |
LGTM. This isn't actually a policy change, so there's no reason for this to go to a CTC meeting imo. |
Thanks very much @zkat ✨ |
c17c6f3
to
f31443b
Compare
@Charlotteis @zkat ok thanks! wasn't sure |
f31443b
to
d293d02
Compare
lgtm... I especially like the inclusion of |
Very nice update. I'm glad the org is taking this direction. |
LGTM |
I agree with @Fishrock123 ... there shouldn't be a need to put this on the meeting agenda. I'd give it another day tho before landing. |
d293d02
to
974331d
Compare
Out of curiosity, why is there an explicit list of characteristics anyway, especially if it could just go on and on forever like this since it's possible for anyone to discriminate for any reason? Isn't "we are committed to providing a friendly, safe and welcoming environment for all" enough? |
LGTM |
@mscdex well presumably, if someone feels excluded from participating because of one of those traits from the list - they might feel better if they know they are explicitly encouraged to participate. Or something like that. |
This is largely why I proposed this in the first place, yeah 😄 |
@mscdex Explicit is better than implicit. One might try to argue that the lack of inclusion of a particular form of bigotry in the list is validation that it's "okay" when it really is not. |
Updates still LGTM |
:lgtm: ✨ |
hey @jasnell do we think we'll merge today or next week? just curious. really proud of our community's response on this thread. go node ❤️ 😊 |
@ashleygwilliams I don't see why we wouldn't merge it today. Since @zkat is a collaborator we defer to her to do the actual merge unless otherwise noted. :) |
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
974331d
to
de0d35f
Compare
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
Landed in master as of de0d35f 🎉 |
💖 |
👍 |
Suggestion: Change |
@chriseppstein patches welcome 😁 |
FWIW, we just added that language to the inclusivity CoC: nodejs/inclusivity#97. Thanks for the suggestion @chriseppstein! |
Closing because it landed :-) We'll definitely get this pulled back into the LTS... hopefully in the next round |
environment for all, regardless of level of experience, gender | ||
identity and expression, sexual orientation, disability, | ||
personal appearance, body size, race, ethnicity, age, religion, | ||
nationality, or other similar characteristic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would or any other characteristic
have been better?
@zkat Can you keep lines in the commit log <= 72 columns next time? Thanks. |
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in.
We also received a request to do this in nodejs/inclusivity#82 so this should resolve that.
This PR would preferably also be merged into LTS, imo.
/cc @nodejs/inclusivity @nodejs/lts @nodejs/documentation