Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix skip message in update-cjs-module-lexer #47701

Merged
merged 1 commit into from
Apr 24, 2023
Merged

tools: fix skip message in update-cjs-module-lexer #47701

merged 1 commit into from
Apr 24, 2023

Conversation

tniessen
Copy link
Member

Refs: #47446

@tniessen tniessen added tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 24, 2023
@tniessen tniessen requested a review from marco-ippolito April 24, 2023 14:54
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8becacb into nodejs:main Apr 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 8becacb

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@tniessen @yjl9903
tools: fix skip message in update-cjs-module-lexer
ccc3b6f 
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@tniessen @yjl9903
tools: fix skip message in update-cjs-module-lexer
e987bcc 
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@tniessen @yjl9903
tools: fix skip message in update-cjs-module-lexer
a8fab90 
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request May 2, 2023
@tniessen @targos
tools: fix skip message in update-cjs-module-lexer
d2994e5 
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
tools: fix skip message in update-cjs-module-lexer
b0134ee 
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen @MoLow
tools: fix skip message in update-cjs-module-lexer
64c3154 
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @panva @targos @richardlau @deokjinkim @marco-ippolito