Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: revert parallel wpt commits #47627

Closed
wants to merge 2 commits into from
Closed

Conversation

panva
Copy link
Member

@panva panva commented Apr 19, 2023

This reverts #47283 and #47376 because the changes in the former allow multi-variant test file workers to be terminated before finishing, not reporting the results at all, see e.g. here in 19.x, 20.x, and nightly columns, those are the ones where #47283 has landed.

I will refactor the WPT Runner instead of constantly fixing the untestable.

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 19, 2023
@panva panva added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Apr 19, 2023
@panva
Copy link
Member Author

panva commented Apr 19, 2023

fast-track PRs that do not need to wait for 48 hours to land. because while these commits are in place we're not actually reporting on WPT failures in workers that get randomly terminated.

@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@nodejs-github-bot
Copy link
Collaborator

panva added 2 commits April 20, 2023 07:28

Partially verified

This commit is signed with the committer’s verified signature.
targos’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
This reverts commit b17227b.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 20, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47627
✔  Done loading data for nodejs/node/pull/47627
----------------------------------- PR info ------------------------------------
Title      test: revert parallel wpt commits (#47627)
Author     Filip Skokan  (@panva)
Branch     panva:wpt-reverts -> nodejs:main
Labels     build, tools, fast-track, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, commit-queue-rebase, dont-land-on-v18.x
Commits    2
 - Revert "tools: ensure failed daily wpt run still generates a report"
 - Revert "test: run WPT files in parallel again"
Committers 1
 - Filip Skokan 
PR-URL: https://github.com/nodejs/node/pull/47627
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matthew Aitken 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47627
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matthew Aitken 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - Revert "tools: ensure failed daily wpt run still generates a report"
   ⚠  - Revert "test: run WPT files in parallel again"
   ℹ  This PR was created on Wed, 19 Apr 2023 20:57:57 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393002791
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393073980
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393228084
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-04-20T06:35:12Z: https://ci.nodejs.org/job/node-test-pull-request/51375/
- Querying data for job/node-test-pull-request/51375/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4752023065

@panva
Copy link
Member Author

panva commented Apr 20, 2023

Landed in 12094bc...607715e

@panva panva closed this Apr 20, 2023
panva added a commit that referenced this pull request Apr 20, 2023
This reverts commit b17227b.

PR-URL: #47627
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
panva added a commit that referenced this pull request Apr 20, 2023
This reverts commit c05689e.

PR-URL: #47627
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@panva
Copy link
Member Author

panva commented Apr 20, 2023

See #47635 for the fix.

targos pushed a commit that referenced this pull request May 2, 2023
This reverts commit b17227b.

PR-URL: #47627
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
targos pushed a commit that referenced this pull request May 2, 2023
This reverts commit c05689e.

PR-URL: #47627
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants