Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add a benchmark for defaultResolve #47543

Merged
merged 2 commits into from
Apr 13, 2023
Merged

benchmark: add a benchmark for defaultResolve #47543

merged 2 commits into from
Apr 13, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 13, 2023

No description provided.

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
@aduh95 aduh95 mentioned this pull request Apr 13, 2023
Merged
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Apr 13, 2023

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1325/

@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Apr 13, 2023
@aduh95 @VoltrexKeyva @GeoffreyBooth
Apply suggestions from code review
7899655 
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
Co-authored-by: Geoffrey Booth <[email protected]>
@GeoffreyBooth GeoffreyBooth removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 13, 2023
JakobJingleheimer
JakobJingleheimer approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4afb25c into nodejs:main Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4afb25c

@aduh95 aduh95 deleted the bench-resolve branch April 13, 2023 20:05
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95 @targos
benchmark: add a benchmark for defaultResolve
936d7cb 
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95 @danielleadams
benchmark: add a benchmark for defaultResolve
fbce3b9 
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@aduh95 @MoLow
benchmark: add a benchmark for defaultResolve
d8233d9 
PR-URL: nodejs#47543
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@anonrig anonrig anonrig approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @anonrig @JakobJingleheimer @VoltrexKeyva