[v19.x] deps: V8: cherry-pick 9ec4e9095a25 #47535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
5 tasks
|
I've just landed #47239 on v19.x-staging to fix our V8 CI for Node.js 19.x (nodejs/build#3221). Could you rebase onto the current v19.x-staging to pick up that change, then I'll kick off the CI runs? |
Original commit message:
[turbofan] Fix 32-to-64 bit spill slot moves
Other optimizations can create a situation where it is valid to treat a
stack slot as either 32-bit (which is what its value was created as) or
64-bit value (to which it was implicitly zero-extended). So when moving
such a value to a register, we cannot use a 32-bit move instruction just
because the source was annotated as such; we must also take the target
slot's representation into account.
Fixed: chromium:1407594
Bug: chromium:1356461
Change-Id: I00d850c11a020b055e90f6107b604cdd267d9b6c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4197349
Auto-Submit: Jakob Kummerow <[email protected]>
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Maya Lekova <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#85501}
Refs: v8/v8@9ec4e90
kleisauke
force-pushed
the
cherrypick-v8-9ec4e9095a25-v19
branch
from
1b6d976 to
00fd5ee
Compare
|
Rebased and bumped the |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Apr 13, 2023
gengjiawen
approved these changes
Apr 14, 2023
richardlau
added
the
author ready
33 tasks
targos
pushed a commit
that referenced
this pull request
May 1, 2023
Original commit message:
[turbofan] Fix 32-to-64 bit spill slot moves
Other optimizations can create a situation where it is valid to treat a
stack slot as either 32-bit (which is what its value was created as) or
64-bit value (to which it was implicitly zero-extended). So when moving
such a value to a register, we cannot use a 32-bit move instruction just
because the source was annotated as such; we must also take the target
slot's representation into account.
Fixed: chromium:1407594
Bug: chromium:1356461
Change-Id: I00d850c11a020b055e90f6107b604cdd267d9b6c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4197349
Auto-Submit: Jakob Kummerow <[email protected]>
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Maya Lekova <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#85501}
Refs: v8/v8@9ec4e90
PR-URL: #47535
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
|
Landed in 8283313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@9ec4e90
Refs: #46446 (comment)
Refs: #47092 (comment)