tools: automate zlib update #47417
Merged
tools: automate zlib update #47417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
marco-ippolito
force-pushed
the
feat/automate-zlib-update
branch
2 times, most recently
from
6f313cd to
c9f1101
Compare
lpinca
reviewed
Apr 5, 2023
|
|
||
| CURRENT_VERSION=$(grep "#define ZLIB_VERSION" "$DEPS_DIR/zlib/zlib.h" | sed -n "s/^.*VERSION \"\(.*\)\"/\1/p") | ||
|
|
||
| NEW_VERSION_ZLIB_H=$(curl -s "https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/zlib.h?format=TEXT" | base64 --decode) |
There was a problem hiding this comment.
This works but it might remain the same for a very long time. It is not very useful. We refer to the tip of the remote main branch to check if an update is needed. However, afaik, we store the current commit SHA only in the commit message.
There was a problem hiding this comment.
I havent found any other solution to check what's the latest version, I think this might be a reasonable compromise and its not very expensive
There was a problem hiding this comment.
That's fine but it probably won't find a new version for years. See https://github.com/madler/zlib/tags.
There was a problem hiding this comment.
@lpinca are you saying that we typically update to something that is not a new release? If so then an option in the script/action to say generate PR based on commit X instead of a new version might make sense.
There was a problem hiding this comment.
are you saying that we typically update to something that is not a new release?
Yes, exactly.
marco-ippolito
force-pushed
the
feat/automate-zlib-update
branch
from
c9f1101 to
210c3bd
Compare
marco-ippolito
added
the
author ready
lpinca
approved these changes
Apr 7, 2023
marco-ippolito
force-pushed
the
feat/automate-zlib-update
branch
2 times, most recently
from
b02200c to
ef67324
Compare
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47417 ✔ Done loading data for nodejs/node/pull/47417 ----------------------------------- PR info ------------------------------------ Title tools: automate zlib update (#47417) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/automate-zlib-update -> nodejs:main Labels meta, tools, author ready Commits 1 - tools: automate zlib update Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: automate zlib update ℹ This PR was created on Wed, 05 Apr 2023 09:59:59 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4678748046 |
marco-ippolito
force-pushed
the
feat/automate-zlib-update
branch
from
ef67324 to
7194af1
Compare
RafaelGSS
approved these changes
Apr 15, 2023
marco-ippolito
force-pushed
the
feat/automate-zlib-update
branch
from
7194af1 to
4c1a1a5
Compare
marco-ippolito
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47417 ✔ Done loading data for nodejs/node/pull/47417 ----------------------------------- PR info ------------------------------------ Title tools: automate zlib update (#47417) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/automate-zlib-update -> nodejs:main Labels meta, tools, author ready Commits 1 - tools: automate zlib update Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: automate zlib update ℹ This PR was created on Wed, 05 Apr 2023 09:59:59 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47417#pullrequestreview-1386302187 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4723740689 |
marco-ippolito
removed
the
commit-queue-failed
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47417 ✔ Done loading data for nodejs/node/pull/47417 ----------------------------------- PR info ------------------------------------ Title tools: automate zlib update (#47417) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/automate-zlib-update -> nodejs:main Labels meta, tools, author ready Commits 1 - tools: automate zlib update Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47417 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: automate zlib update ℹ This PR was created on Wed, 05 Apr 2023 09:59:59 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376059006 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47417#pullrequestreview-1376413213 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47417#pullrequestreview-1386302187 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4730739601 |
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8f879de |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
9 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47417 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
@nodejs/security-wg