-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: fix invalid requirementsURL #47378
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230403_benchmark_fix_requirementsURL
Apr 3, 2023
Merged
benchmark: fix invalid requirementsURL #47378
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:230403_benchmark_fix_requirementsURL
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
Issues and PRs related to the benchmark subsystem.
http
Issues or PRs related to the http subsystem.
labels
Apr 3, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark).
deokjinkim
force-pushed
the
230403_benchmark_fix_requirementsURL
branch
from
April 3, 2023 09:04
30d760e
to
7640c68
Compare
anonrig
approved these changes
Apr 3, 2023
anonrig
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 3, 2023
VoltrexKeyva
approved these changes
Apr 3, 2023
VoltrexKeyva
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Apr 3, 2023
Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve. |
lpinca
approved these changes
Apr 3, 2023
deokjinkim
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 3, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 3, 2023
Landed in edaa9f4 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: #47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing` (not benchmark). PR-URL: nodejs#47378 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
fast-track
PRs that do not need to wait for 48 hours to land.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location of
writing-and-running-benchmarks.md
isdoc/contributing
(not benchmark).