-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v19.x backport] deps: V8: cherry-pick cb30b8e17429 #47307
[v19.x backport] deps: V8: cherry-pick cb30b8e17429 #47307
Conversation
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I just landed V8 11.3 on main and it contains this fix. You might want to backport to v19.x-staging instead. |
Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: nodejs#43370 Signed-off-by: Darshan Sen <[email protected]>
995715a
to
97f9fbc
Compare
@targos done, could you PTAL? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@targos it seems like the only remaining CI failure on this PR is coming from https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5269/: Testing hash seed
export PATH="/usr/bin:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" && \
/usr/bin/python3.9 deps/v8/tools/run-tests.py --gn --arch=ppc64 --progress=dots --timeout=120 intl \
mjsunit cctest debugger inspector message preparser \
--json-test-results /home/iojs/build/workspace/node-test-commit-v8-linux/v8-tap.json --slow-tests-cutoff 1000000
Traceback (most recent call last):
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/run-tests.py", line 11, in <module>
from testrunner import standard_runner
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/standard_runner.py", line 16, in <module>
from testrunner.testproc.progress import ResultsTracker, ProgressProc
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/progress.py", line 9, in <module>
from testrunner.testproc.resultdb import ResultDBIndicator
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/testproc/resultdb.py", line 8, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
make: *** [Makefile:713: test-v8] Error 1
Build step 'Execute shell' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com vieuxtech@gmail.com info@bnoordhuis.nl
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE which looks totally unrelated. Is this a known issue on v19.x-staging? Should we land this PR manually irrespective of that failure? |
Yes, it's a known issue fixed by #47239 |
Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: #43370 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #47307 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 5ddd1c9 |
Original commit message: Fix compilation error in platform.h for ASAN The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#86235} Refs: v8/v8@cb30b8e Refs: #43370 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #47307 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original commit message:
Refs: v8/v8@cb30b8e
Refs: #43370