test: update wasm/jsapi WPT #47210
Merged
test: update wasm/jsapi WPT #47210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
33 tasks
lpinca
approved these changes
Mar 24, 2023
github-actions
bot
removed
the
request-ci
This was referenced Mar 30, 2023
targos
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47210 ✔ Done loading data for nodejs/node/pull/47210 ----------------------------------- PR info ------------------------------------ Title test: update wasm/jsapi WPT (#47210) Author Michaël Zasso (@targos) Branch targos:wpt-wasm-jsapi -> nodejs:main Labels test, needs-ci Commits 1 - test: update wasm/jsapi WPT Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/47210 Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47210 Reviewed-By: Michael Dawson Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: update wasm/jsapi WPT ℹ This PR was created on Wed, 22 Mar 2023 10:11:29 GMT ✔ Approvals: 2 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47210#pullrequestreview-1353460638 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47210#pullrequestreview-1357210797 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-31T07:11:05Z: https://ci.nodejs.org/job/node-test-pull-request/50733/ - Querying data for job/node-test-pull-request/50733/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4573181574 |
|
I need a new review, please. My force push was just a rebase. |
panva
removed
the
commit-queue-failed
panva
approved these changes
Mar 31, 2023
panva
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0b2555c |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47210 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47210 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47210 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
PR-URL: #47210 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47210 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.