Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unused callback variables removed #47167

Merged
merged 1 commit into from
Apr 10, 2023
Merged

test: unused callback variables removed #47167

merged 1 commit into from
Apr 10, 2023

Conversation

angellovc
Copy link
Contributor

Non used variables were removed from stream-exception test

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 19, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50477/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50487/

@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Open
19 tasks
@tniessen
Copy link
Member

Hi @angellovc and thank you for the contribution! Please take a look at the commit message guidlines. A better commit message would be test: remove unused callback variables, for example.

@angellovc
Copy link
Contributor Author

Hi @angellovc and thank you for the contribution! Please take a look at the commit message guidlines. A better commit message would be test: remove unused callback variables, for example.

Of course I will, thanks. Is it necessary to change this one?

@debadree25 debadree25 mentioned this pull request Mar 21, 2023
Closed
@github-actions github-actions bot mentioned this pull request Mar 22, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50541/

@github-actions github-actions bot mentioned this pull request Mar 23, 2023
Open
33 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50673/

This was referenced Mar 30, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50846/

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@angellovc @Trott
test: remove unused callback variables
e301ba4 
Unused variables were removed from stream-exception test.

PR-URL: nodejs#47167
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@Trott Trott force-pushed the angellovc/test-unused-variables-removed-from-stream-exceptions branch from fb0a3a4 to e301ba4 Compare April 10, 2023 17:43
@Trott Trott merged commit e301ba4 into nodejs:main Apr 10, 2023
@Trott
Copy link
Member

Trott commented Apr 10, 2023

Landed in e301ba4

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@angellovc @RafaelGSS
test: remove unused callback variables
81ad73a 
Unused variables were removed from stream-exception test.

PR-URL: #47167
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@angellovc @danielleadams
test: remove unused callback variables
f24d061 
Unused variables were removed from stream-exception test.

PR-URL: #47167
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@angellovc @MoLow
test: remove unused callback variables
7c4178c 
Unused variables were removed from stream-exception test.

PR-URL: nodejs#47167
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@angellovc @nodejs-github-bot @tniessen @Trott @lpinca @watilde @anonrig @cjihrig @debadree25 @panva