doc: clarify protocol default in http.request() #4714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: nodejs#4712
|
LGTM. Good catch. |
jasnell
added
http
cjihrig
added a commit
that referenced
this pull request
Jan 15, 2016
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: #4712 PR-URL: #4714 Reviewed-By: James M Snell <[email protected]>
|
Thanks for the review. Landed in 212a44d. |
jasnell
pushed a commit
that referenced
this pull request
Jan 15, 2016
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: #4712 PR-URL: #4714 Reviewed-By: James M Snell <[email protected]>
|
Landed in v4.x-staging in 7e1564d |
evanlucas
pushed a commit
that referenced
this pull request
Jan 18, 2016
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: #4712 PR-URL: #4714 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: #4712 PR-URL: #4714 Reviewed-By: James M Snell <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: nodejs#4712 PR-URL: nodejs#4714 Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously listed default of
'http'is incorrect, and causes an error to be thrown. This commit changes it to the correct value of'http:'.Fixes: #4712