test: mark test-http-max-sockets as flaky on win32 #47134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
windows
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
anonrig
approved these changes
Mar 17, 2023
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Test was correctly detected as being flaky in the previous Jenkins run, but some other tests on other platforms flaked, too... |
BethGriggs
approved these changes
Mar 17, 2023
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9e9f68a |
23 tasks
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
Refs: #47116 PR-URL: #47134 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
This was referenced Mar 19, 2023
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: #47116 PR-URL: #47134 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Windows CI build trend:
I am not sure if marking it as flaky is going to be enough. Maybe we have to skip it entirely, but that's something that we should try to avoid.
Refs: #47116