stream: don't wait for next item in take when finished #47132

rluvaton · 2023-03-17T09:56:39Z

currently, in the take operator, we wait for the next item in the stream to check whether to finish or not

now we don't need to wait anymore

nodejs-github-bot · 2023-03-17T09:56:44Z

Review requested:

@nodejs/streams

rluvaton · 2023-03-17T09:59:11Z

test/parallel/test-stream-drop-take.js

+    .then(common.mustCall(() => {
+      strictEqual(reached, false);
+    }))
+    .finally(() => resolve());


We don't have to do it. right?
the entire closure will be GCed...

rluvaton · 2023-03-17T10:15:06Z

FYI, I'm also trying to fix gonna be in another PR the need to wait for another item to abort a stream, this affect map, take and the rest

Edit: The error seems much larger and I don't have much time now to further debug it so opened an issue #47133

nodejs-github-bot · 2023-03-17T13:13:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50417/

mcollina

lgtm

nodejs-github-bot · 2023-03-18T13:00:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50445/

rluvaton · 2023-03-18T16:53:53Z

Hey @mcollina, @ronag
I really don't understand why the CI failed can you help me out please so I can merge this?

rluvaton · 2023-03-19T12:15:18Z

Hey @debadree25, any idea why the test commit CI fail (the Jenkins one that is called when adding request-ci label)

It's the second time now

debadree25 · 2023-03-19T15:11:00Z

Seems to be flaky, I have restarted the build

rluvaton · 2023-03-19T15:14:11Z

Thanks, what the difference between the test commit Jenkins job and the GitHub Actions one? Is there something I'm doing wrong?

debadree25 · 2023-03-19T15:56:08Z

No no nothing wrong from your side at least doesn't seem like it, the Jenkins jobs basically run the tests in the other various platforms and configurations that nodejs needs to support but github actions dont yet, some of these maybe flaky or sometimes there maybe related failure which you can checkout by going on the link that the CI bot comments

nodejs-github-bot · 2023-03-19T16:00:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50470/

nodejs-github-bot · 2023-03-19T17:21:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/47132 ✔ Done loading data for nodejs/node/pull/47132 ----------------------------------- PR info ------------------------------------ Title stream: don't wait for next item in take when finished (#47132) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:dont-wait-for-next-item-even-when-finish -> nodejs:main Labels author ready, needs-ci Commits 3 - stream: dont wait for next item in take when finished - stream: update comment and lint - stream: trigger CI again Committers 1 - Raz Luvaton <[email protected]> PR-URL: https://github.com/nodejs/node/pull/47132 Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Erick Wendel Reviewed-By: Matteo Collina Reviewed-By: Debadree Chatterjee ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47132 Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Erick Wendel Reviewed-By: Matteo Collina Reviewed-By: Debadree Chatterjee -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 17 Mar 2023 09:56:39 GMT ✔ Approvals: 5 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/47132#pullrequestreview-1345627091 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47132#pullrequestreview-1345903804 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/47132#pullrequestreview-1346006254 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47132#pullrequestreview-1346652710 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/47132#pullrequestreview-1347525558 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-19T16:00:00Z: https://ci.nodejs.org/job/node-test-pull-request/50470/ - Querying data for job/node-test-pull-request/50470/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47132 From https://github.com/nodejs/node * branch refs/pull/47132/merge -> FETCH_HEAD ✔ Fetched commits as fbd526b15a0b..f233a6dff4d6 -------------------------------------------------------------------------------- [main 0c47595d4f] stream: dont wait for next item in take when finished Author: Raz Luvaton <[email protected]> Date: Fri Mar 17 11:53:51 2023 +0200 2 files changed, 27 insertions(+), 2 deletions(-) [main 74da41c71b] stream: update comment and lint Author: Raz Luvaton <[email protected]> Date: Fri Mar 17 11:57:45 2023 +0200 1 file changed, 3 insertions(+), 3 deletions(-) The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch main
Your branch is ahead of 'origin/main' by 2 commits.
(use "git push" to publish your local commits)

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
labels.json
output

nothing added to commit but untracked files present (use "git add" to track)
✘ Failed to apply patches

https://github.com/nodejs/node/actions/runs/4461834999

rluvaton · 2023-03-21T08:20:32Z

@debadree25 any update?

Is this happening only for my PR or for all node PRs? 😬😬

debadree25 · 2023-03-21T09:31:52Z

I think this might be happening for all PRs but I am not sure nonetheless I am requesting fresh ci again let's hope it succeeds so sorry for the delay but better to be safe and correct 😅

nodejs-github-bot · 2023-03-21T16:58:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50528/

nodejs-github-bot · 2023-03-22T04:47:00Z

Landed in 22537f3

PR-URL: #47132 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023

ronag approved these changes Mar 17, 2023

View reviewed changes

rluvaton commented Mar 17, 2023

View reviewed changes

anonrig approved these changes Mar 17, 2023

View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 17, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023

ErickWendel approved these changes Mar 17, 2023

View reviewed changes

mcollina approved these changes Mar 17, 2023

View reviewed changes

github-actions bot mentioned this pull request Mar 18, 2023

CI Reliability 2023-03-18 nodejs/reliability#527

Open

23 tasks

github-actions bot mentioned this pull request Mar 19, 2023

CI Reliability 2023-03-19 nodejs/reliability#528

Open

19 tasks

debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2023

This comment was marked as outdated.

Sign in to view

debadree25 approved these changes Mar 19, 2023

View reviewed changes

debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 19, 2023

debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 19, 2023

debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 20, 2023

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Mar 21, 2023

CI Reliability 2023-03-21 nodejs/reliability#531

Open

19 tasks

This comment was marked as outdated.

Sign in to view

debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2023

This comment was marked as outdated.

Sign in to view

debadree25 mentioned this pull request Mar 21, 2023

Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200

Closed

github-actions bot mentioned this pull request Mar 22, 2023

CI Reliability 2023-03-22 nodejs/reliability#532

Open

19 tasks

debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023

nodejs-github-bot merged commit 22537f3 into nodejs:main Mar 22, 2023

github-actions bot mentioned this pull request Mar 23, 2023

CI Reliability 2023-03-23 nodejs/reliability#533

Open

33 tasks

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

RafaelGSS mentioned this pull request Apr 6, 2023

v19.9.0 proposal #47441

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: don't wait for next item in take when finished #47132

stream: don't wait for next item in take when finished #47132

rluvaton commented Mar 17, 2023

nodejs-github-bot commented Mar 17, 2023

rluvaton Mar 17, 2023

rluvaton commented Mar 17, 2023 •

edited

Loading

nodejs-github-bot commented Mar 17, 2023

mcollina left a comment

nodejs-github-bot commented Mar 18, 2023

rluvaton commented Mar 18, 2023 •

edited

Loading

This comment was marked as outdated.

rluvaton commented Mar 19, 2023 •

edited

Loading

debadree25 commented Mar 19, 2023

rluvaton commented Mar 19, 2023

debadree25 commented Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

rluvaton commented Mar 21, 2023

debadree25 commented Mar 21, 2023

This comment was marked as outdated.

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 22, 2023

stream: don't wait for next item in take when finished #47132

stream: don't wait for next item in take when finished #47132

Conversation

rluvaton commented Mar 17, 2023

nodejs-github-bot commented Mar 17, 2023

rluvaton Mar 17, 2023

Choose a reason for hiding this comment

rluvaton commented Mar 17, 2023 • edited Loading

nodejs-github-bot commented Mar 17, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 18, 2023

rluvaton commented Mar 18, 2023 • edited Loading

This comment was marked as outdated.

rluvaton commented Mar 19, 2023 • edited Loading

debadree25 commented Mar 19, 2023

rluvaton commented Mar 19, 2023

debadree25 commented Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

rluvaton commented Mar 21, 2023

debadree25 commented Mar 21, 2023

This comment was marked as outdated.

nodejs-github-bot commented Mar 21, 2023

nodejs-github-bot commented Mar 22, 2023

rluvaton commented Mar 17, 2023 •

edited

Loading

rluvaton commented Mar 18, 2023 •

edited

Loading

rluvaton commented Mar 19, 2023 •

edited

Loading