src: fix typo in process.env accessor error message #47014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
cjihrig
approved these changes
Mar 8, 2023
anonrig
approved these changes
Mar 8, 2023
|
Can you update your commit message to conform to commit style guidelines? @moritzraho |
addaleax
approved these changes
Mar 8, 2023
RaisinTen
approved these changes
Mar 9, 2023
lpinca
approved these changes
Mar 27, 2023
github-actions
bot
removed
the
request-ci
This was referenced Mar 30, 2023
|
@moritzraho can you please fix the lint issue? |
|
@lpinca yup done |
|
I hate to bring it up - but can someone please tell me it's OK for this not to be semver-major because even though it changes an error message it's extremely unlikely fro this particular error and error message to be checked in a way where this can break stuff in practice? |
|
It changes the error message, but it doesn't change the error code, so this shouldn't need to be semver-major. |
This was referenced Apr 12, 2023
jasnell
approved these changes
Apr 15, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 070c9a8 |
35 tasks
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny commit to fix a missing white space in the error message "'process.env' does not accept anaccessor(getter/setter) descriptor".