Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: allow extension of user provided URL objects #46989

Merged
merged 2 commits into from
Mar 19, 2023
Merged

url: allow extension of user provided URL objects #46989

merged 2 commits into from
Mar 19, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 7, 2023

Fixes: #46981

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 7, 2023
@aduh95 aduh95 mentioned this pull request Mar 7, 2023
Closed
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
lib/internal/url.js Show resolved Hide resolved
lib/internal/url.js Show resolved Hide resolved
@anonrig anonrig mentioned this pull request Mar 7, 2023
Closed
trentm
trentm reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (caveat: I'm not a nodejs reviewer)

@aduh95 aduh95 requested a review from anonrig March 18, 2023 11:19
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50443/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50452/

@github-actions github-actions bot mentioned this pull request Mar 19, 2023
Open
19 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit ad2c3c0 into nodejs:main Mar 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ad2c3c0

This was referenced Mar 20, 2023
Open
Open
Open
@trentm trentm mentioned this pull request Mar 30, 2023
Closed
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@aduh95 @RafaelGSS
url: allow extension of user provided URL objects
306d230 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@aduh95 @RafaelGSS
url: allow extension of user provided URL objects
0b565e8 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@anonrig anonrig mentioned this pull request Jun 24, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
2950c0d 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
afe3227 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
482ba0a 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95 @danielleadams
url: allow extension of user provided URL objects
b04ea5a 
PR-URL: #46989
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 6, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
5861a42 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
ccd73d6 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@aduh95 @anonrig
url: allow extension of user provided URL objects
353bab0 
PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@aduh95 @danielleadams
url: allow extension of user provided URL objects
4784e64 
PR-URL: #46989
Backport-PR-URL: #48345
Fixes: #46981
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu left review comments

@trentm trentm trentm left review comments

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new internal isURL check can result in http.request() option fields being ignored
6 participants
@aduh95 @nodejs-github-bot @trentm @TimothyGu @anonrig @danielleadams